Fix Googleplay Podcast explicit type #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Providing deprecated fallback to maintain binary compatibility
rock3r
commented
May 21, 2021
| public fun <init> (Ljava/lang/String;Ljava/lang/String;Ljava/util/List;Ljava/lang/String;Ljava/lang/Boolean;ZLdev/stalla/model/HrefOnlyImage;Ljava/lang/String;)V | ||
| public synthetic fun <init> (Ljava/lang/String;Ljava/lang/String;Ljava/util/List;Ljava/lang/String;Ljava/lang/Boolean;ZLdev/stalla/model/HrefOnlyImage;Ljava/lang/String;ILkotlin/jvm/internal/DefaultConstructorMarker;)V | ||
| public static fun builder ()Ldev/stalla/builder/podcast/PodcastGoogleplayBuilder; | ||
| public final fun component1 ()Ljava/lang/String; | ||
| public final fun component2 ()Ljava/lang/String; | ||
| public final fun component3 ()Ljava/util/List; | ||
| public final fun component4 ()Ljava/lang/String; | ||
| public final fun component5 ()Ljava/lang/Boolean; |
There was a problem hiding this comment.
This is the first binary incompatible change
rock3r
commented
May 21, 2021
| public final fun component6 ()Z | ||
| public final fun component7 ()Ldev/stalla/model/HrefOnlyImage; | ||
| public final fun component8 ()Ljava/lang/String; | ||
| public final fun copy (Ljava/lang/String;Ljava/lang/String;Ljava/util/List;Ljava/lang/String;Ljava/lang/Boolean;ZLdev/stalla/model/HrefOnlyImage;Ljava/lang/String;)Ldev/stalla/model/googleplay/PodcastGoogleplay; |
There was a problem hiding this comment.
This is the other binary incompatible change
|
I just had a confirming look at the Google Play XML Schema, and it seems it's intended behaviour that |
|
I have no backing data on this at the moment, but I can add this in the future. |
|
Ah, my bad. I only checked the xsd element definition and not the description 😅 Suppose we can drop this then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the PodcastGoogleplay was using a boolean to map the
explicitflag, instead of theExplicitTypeenum. This PR fixes that. It is a non-source-breaking API change, but it is a binary incompatible change.Do you have any data from your recent explorations about the values that people use for this, and other,
explicittags? Would be worth checking so we can map additional values if need be.