Change the total_points method #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpgn
requested changes
Dec 19, 2018
There was a problem hiding this comment.
Hello,
Nice catch :)
Can you check with this code ?
r = requests.get('https://www.root-me.org/fr/Communaute/Classement/')
regex = r'<td><a href=".*" title=".*">([0-9]+)</a></td>'
matches = re.search(regex, r.text)
if matches:
data['total_points'] = "{group}".format(group = matches.group(1))This solution avoid the sum part
| @@ -73,11 +73,11 @@ def update(): | |||
| print("[+] Starting Update generic information") | |||
|
|
|||
| # get generic data | |||
| r = requests.get('https://www.root-me.org/fr/Communaute/Classement/') | |||
| regex = r'<a href=".*?>([0-9]+)</a>' | |||
There was a problem hiding this comment.
check with :
r'</a>'<td><a href=".*" title=".*">([0-9]+)</a></td>'
There was a problem hiding this comment.
I don't see where you can find the total_points value in this page to be honest.
I'm testing with Chrome and don't see anything.
I think you just catch the score of the number one in the scoreboard, don't you?
There was a problem hiding this comment.
This is a poor solution I have to admit ^^ Your solution is better 👍 PR accepted
mpgn
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The total_points is now incorrect. I'm suspecting Root-Me to have changed something.
I used another method where I add all points to get the correct total_points value.
Not sure you use it anymore btw.