Corrections to collectives chapter: fix examples and remove deprecated functions

[mpiforumbot]

Originally by moody20 on 2009-02-06 18:51:07 -0600

---

Corrections to collectives chapter: fix examples and remove deprecated functionsAuthor: Adam Moody

Description

This ticket fixes broken examples (typos and errors) and uses new functions in place of deprecated functions ( [ticket/12 'Ticket 12'] ) throughout the chapter. A diff file is attached of the latex with the new changes applied to coll.tex.

Proposed Solution

p 138, line 1

deprecated: "MPI_Type_extent()" --> "MPI_Type_get_extent()"

p 144, line 23

deprecated: "MPI_Type_struct" --> "MPI_Type_create_struct"

p 145, line 44

delete: "stride, " (not used)

p 145, line 46

typo: "types[2]" --> "type[2]"

p 146, line 26

deprecated: "MPI_Type_struct" --> "MPI_Type_create_struct"

p 151, line 14

remove: "bufsize, " (not used)

p 153, line 3

typo: "MPI_GATHER" --> "MPI_Gather" (use C syntax like other illustrations)

p 165, line 31

deprecated: "MPI_TYPE_STRUCT" --> "MPI_TYPE_CREATE_STRUCT"

p 167, line 25

correction: "MPI_Reduce( in, out," --> "MPI_Reduce( &in, &out"

p 171, line 33

correction: "MPI_Op_create( myProd, True" --> "MPI_Op_create( myProd, 1"

p 177, line 2

typo: "SeqScanPair" --> "SegScanPair"

p 177, line 11

deprecated: "MPI_Address" --> "MPI_Get_address"

p 177, line 12

deprecated: "MPI_Address" --> "MPI_Get_address"

p 177, line 15

deprecated: "MPI_Type_struct" --> "MPI_Type_create_struct"

p 177, line 21

correction: "MPI_Scan( a, answer" --> "MPI_Scan( &a, &answer"

Impact on Implementations

None: only typo/deprecated function corrections to text in the standard.

Impact on Applications / Users

None: only typo/deprecated function corrections to text in the standard.

Alternative Solutions

N/A

Entry for the Change Log

No changes for implementors or users to be documented.

[mpiforumbot]

Originally by moody20 on 2009-02-06 18:52:32 -0600

---

Attachment added: coll.tex.diff (6.3 KiB)
diff of chap-coll/coll.tex latex with new changes

[mpiforumbot]

Originally by traff on 2009-02-09 17:07:35 -0600

---

Reviewed, fine

[mpiforumbot]

Originally by htor on 2009-02-09 23:09:47 -0600

---

reviewed ok

[mpiforumbot]

Originally by jsquyres on 2009-02-10 09:08:49 -0600

---

Can you please fill in the rest of the sections of the proposal?

Thanks!

[mpiforumbot]

Originally by jsquyres on 2009-02-10 09:21:01 -0600

---

Forgot to mention: the proposed solution reviews fine.

[mpiforumbot]

Originally by htor on 2009-06-19 16:04:01 -0500

---

Implemented this ticket in rev 254. The updated page and a diff are attached (coll.pdf). Please ignore the page number and review the change for correctness!

Not all page/line numbers in the ticket were correct. However, I fixed all occurrences -- here are the corrections:

p 145, line 44

delete: "stride, " (not used)

--> found it on page 146:6

p 145, line 46

typo: "types[2]" --> "type[2]"

--> found it on page 146:7

p 146, line 26

deprecated: "MPI_Type_struct" --> "MPI_Type_create_struct"

--> found it on page 146:36

[mpiforumbot]

Originally by RolfRabenseifner on 2009-06-23 11:18:36 -0500

---

PDF-Review: three errors found, therefore reset to "Passed":

• p 145, line 46: typo: "types[2]" --> "type[2]" [[BR]]
  --> found it on page 146:7

  was not implemented. The s was marked as changed, instead of deleting it.
  You shoud use the macro MPIdelete instead of MPIupdate (as you have done
  correctly one line before in coll.tex).
  The rest of line 1632 in coll.tex (SVN version 257) should be okay.

• p 167, line 25: correction: "MPI_Reduce( in, out," --> "MPI_Reduce( &in, &out"

  was not implemented in coll.tex

• Instead of this change on p167:25, the change was implemented on p166:7.
  Here, in and out are arrays. Therefore "&" is wrong.
  See p37:44 and p38:4 in your coll[1].pdf .
  This wrong correction must be removed.

[mpiforumbot]

Originally by htor on 2009-06-23 12:18:36 -0500

---

You're right -- both mistakes were introduced in the last cleanup. They should be fixed now (rev 258 and attached coll.pdf). Thanks!

[mpiforumbot]

Originally by moody20 on 2009-06-29 15:23:26 -0500

---

Rolf,
I think the proposed p167:25 change is still correct and needed. In this particular example (Example 5.19) in and out are declared as scalar variables (see p167:8-12).
-Adam

[mpiforumbot]

Originally by moody20 on 2009-07-06 17:47:14 -0500

---

No, nevermind. Sorry, Rolf, I think I misinterpreted what you were saying. The text in the current coll.pdf looks to be correct.

[mpiforumbot]

Originally by RolfRabenseifner on 2009-07-13 09:16:59 -0500

---

PDF-review: OKAY

[mpiforumbot]

Originally by moody20 on 2009-07-20 17:01:40 -0500

---

PDF-review: Ok

[mpiforumbot]

Originally by jsquyres on 2009-07-21 11:43:33 -0500

---

PDF review: ok.

But what about the extra comma at the end of the MPI_Gather() "example" on coll.pdf page 25 line 4? Should that also be removed (and within the purview of editorial changes)?

[mpiforumbot]

Originally by htor on 2009-07-21 11:50:42 -0500

---

Attachment added: coll.pdf (379.0 KiB)

[mpiforumbot]

Originally by htor on 2009-07-21 11:52:56 -0500

---

ok, I removed the additional comma in r294. The new pdf is attached (includes now all previous tickets)! Btw., I see no need to invalidate the PDF reviews (do svn diff -r293:294 in order to check the edit).

[mpiforumbot]

Originally by traff on 2009-07-22 09:30:29 -0500

---

PDF-review: OK

(Noted that the examples here are inconsistent in their use of space after "," - doesn't look nice, but I will not file a ticket...)

[mpiforumbot]

Originally by gropp on 2009-07-22 12:36:21 -0500

---

WDG - Reviewed and complete.

[mpiforumbot]

Originally by htor on 2009-07-24 11:01:39 -0500

---

All PDF reviews done -> completed

[mpiforumbot]

Originally by jsquyres on 2010-09-18 05:06:52 -0500

---

This ticket is (long-since) complete; marking it resolved/text committed.