Typo in description of MPI_Cart_shift

[mpiforumbot]

Originally by rsthakur on 2008-10-14 14:49:45 -0500

---

Typo on pg 253, ln 22: "the coordinate which value is modified" should be "the coordinate whose value is modified". Also, this part of the sentence is confusing because no coordinate value is actually modified by the function.

Also, same page, ln 23-24: "The coordinates are numbered from 0 to ndims-1, when ndims is the number of dimensions" should be "The dimensions are numbered from 0 to ndims-1, where ndims is the number of dimensions"

History

Been there since 1.0 I think

Proposed Solution

pg 253, ln 22-23: change the sentence "The direction argument indicates the dimension of the shift, i.e., the coordinate which value is modified by the shift."

to

"The direction argument indicates the coordinate dimension to be traversed by the shift."

pg 253, ln 23-24: Change "The coordinates are numbered from 0 to ndims-1, when ndims is the number of dimensions" to "The dimensions are numbered from 0 to ndims-1, where ndims is the number of dimensions"

Impact on Implementations

None

Impact on Applications / Users

None

Alternative Solutions

None

Entry for the Change Log

None

[mpiforumbot]

Originally by rsthakur on 2008-12-02 13:32:23 -0600

---

Dave, Jesper, Adam,
Could you be the reviewers for this one?

Rajeev

[mpiforumbot]

Originally by goodell on 2008-12-02 13:53:10 -0600

---

This looks good, although I would also change the "when" in the following sentence to read "where". This would then become "The coordinates are numbered from 0 to ndims-1, where ndims is the number of dimensions."

[mpiforumbot]

Originally by traff on 2008-12-03 03:52:52 -0600

---

Replying to goodell:

This looks good, although I would also change the "when" in the following sentence to read "where". This would then become "The coordinates are numbered from 0 to ndims-1, where ndims is the number of dimensions."

Is fine. I also agree with Dave's suggestion. Rajeev, can you somehow add that to the proposal text?

Jesper

[mpiforumbot]

Originally by moody20 on 2008-12-04 19:31:43 -0600

---

I generally agree with this change and Dave's suggestion. However, I propose the following, which I find to be clearer:

The direction argument indicates the dimension of the shift, i.e., the coordinate direction to be traversed by the shift. The dimensions are numbered from 0 to ndims-1, where ndims is the number of dimensions.

[mpiforumbot]

Originally by rsthakur on 2008-12-05 14:49:42 -0600

---

Reviewers are Jesper, Dave Goodell, and Adam Moody.

[mpiforumbot]

Originally by rsthakur on 2008-12-05 15:22:14 -0600

---

I have incorporated Adam and Dave's suggestions. Please take a look at it again because I have compacted the first sentence.

[mpiforumbot]

Originally by moody20 on 2008-12-05 16:35:22 -0600

---

Hi Rajeev,
Thanks for the update. There was one other item in my suggestion which I wasn't sure whether you have included:

Change:
"The coordinates are numbered from 0 to ndims-1, ..."
To:
"The dimensions are numbered from 0 to ndims-1, ..."
(or: "The coordinate dimensions are numbered from 0 to ndims-1, ...")

[mpiforumbot]

Originally by rsthakur on 2008-12-06 18:32:44 -0600

---

Adam,
You have a sharp eye. Among all these errors, I saw only the first one, which instead of whose :-). I have made the change.

Rajeev

[mpiforumbot]

Originally by moody20 on 2008-12-16 17:42:07 -0600

---

The current proposed solution looks good to me.

[mpiforumbot]

Originally by bronis on 2008-12-16 18:06:28 -0600

---

Reviewed. The change of "coordinates" to "dimensions" is fine. The change of "which" to "whose" is incorrect; we should not anthropomorphize the coordinate. I suggest instead we use "the coordinate for which the value is modified".

[mpiforumbot]

Originally by bronis on 2008-12-16 18:13:35 -0600

---

Reviewed actual proposed solution instead of the description. It is fine.

[mpiforumbot]

Originally by traff on 2009-07-13 10:23:39 -0500

---

Chapter editor (Jesper) has performed update, reviewers please check

[mpiforumbot]

Originally by RolfRabenseifner on 2009-07-13 13:46:04 -0500

---

PDF-review: The text is correct, but the empty line after the new red text should be removed.

[mpiforumbot]

Originally by traff on 2009-07-14 08:16:36 -0500

---

thanks, done

[mpiforumbot]

Originally by traff on 2009-07-14 08:17:02 -0500

---

Attachment added: ticket41.pdf (33.3 KiB)

[mpiforumbot]

Originally by RolfRabenseifner on 2009-07-16 03:01:08 -0500

---

PDF-review: Okay.

[mpiforumbot]

Originally by htor on 2009-07-17 13:21:34 -0500

---

PDF-review: OK

[mpiforumbot]

Originally by gropp on 2009-07-22 11:30:00 -0500

---

WDG - Reviewed and complete.

[mpiforumbot]

Originally by rsthakur on 2009-07-22 16:58:15 -0500

---

PDF review: ok

[mpiforumbot]

Originally by jsquyres on 2010-09-18 05:00:43 -0500

---

This ticket is (long-since) complete; marking it resolved/text committed.