Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong term "process group with Cartesian structure" in section 7.5.5 #311

Closed
cniethammer opened this issue Sep 16, 2020 · 7 comments
Closed
Assignees
Labels
chap-topologies Process Topologies Chapter Committee errata Errata items for the previous MPI Standard passed final vote Passed the final formal vote
Milestone

Comments

@cniethammer
Copy link

cniethammer commented Sep 16, 2020

Problem

The text describing MPI_Cart_rank in Section 7.5.5 uses the term "process group with Cartesian structure".
This is wrong, as topology information is added to communicators as specified in 7.3.
So, the interface of MPI_Cart_rank is build around a communicator as input - and not a process group.

Proposal

Replace "process group with Cartesian structure" with "communicator with an associated Cartesian topology"

Impact on Implementations

  • Behavior of implementation clarified

Impacts on Users

  • Behavior of implementation clarified

References

PR: https://github.com/mpi-forum/mpi-standard/pull/280
The latest PDF file (chapter with marked changes): topol_fix-unspecified-cartesian-process-group.pdf

@RolfRabenseifner RolfRabenseifner added the errata Errata items for the previous MPI Standard label Sep 23, 2020
@tonyskjellum
Copy link

tonyskjellum commented Sep 30, 2020

As discussed, this needs to move to and through a committee. @GuillaumeMercier --- are you OK with my putting through the Collective et al. WG? I think you said that :-) Please advise.

We should put this forward as an erratum. I will look for @cniethammer (Christoph's) other ones too.

@RolfRabenseifner, please do not create crypto-errata without WG :-) Wait---Now I see, you are the chapter author for the Topologies WG :-)

Thank you all.

@tonyskjellum tonyskjellum added this to the 2020-12 milestone Sep 30, 2020
@tonyskjellum
Copy link

tonyskjellum commented Sep 30, 2020

@cniethammer , you need to do your PR through the right WG's github, not through your personal one. That way, it is fully WG-accessible and shared with the requisite WG. Once I confirm with @GuillaumeMercier , we will do so under collective or topology github presence, and you can push your branch there, and do a new PR. Personal forks are not the right process!
Thank you, Tony

@GuillaumeMercier
Copy link

@tonyskjellum: you can take over this issue/PR in your own WG if you wish.

@cniethammer
Copy link
Author

@cniethammer , you need to do your PR through the right WG's github, not through your personal one. That way, it is fully WG-accessible and shared with the requisite WG. Once I confirm with @GuillaumeMercier , we will do so under collective or topology github presence, and you can push your branch there, and do a new PR. Personal forks are not the right process!
Thank you, Tony

Thanks.
Waiting for a go to move and make the PR at the WG repo.

@tonyskjellum tonyskjellum added the chap-topologies Process Topologies Chapter Committee label Sep 30, 2020
@wesbland
Copy link
Member

wesbland commented Oct 7, 2020

Is this intended for MPI 4.0 or MPI 4.1?

@cniethammer
Copy link
Author

@RolfRabenseifner or @tonyskjellum could one of you label this for mpi-4.0

Chapter PDF with marked change is attached to the initial comment.

@wesbland wesbland added this to To Do in MPI 4.0 Ratification via automation Oct 23, 2020
@wesbland wesbland moved this from To Do to In Progress (Errata) in MPI 4.0 Ratification Oct 23, 2020
@wesbland wesbland moved this from In Progress (Errata) to Ready to Merge in MPI 4.0 Ratification Nov 14, 2020
@wesbland
Copy link
Member

wesbland commented Dec 8, 2020

2020-12-07 Errata vote results

Yes No Abstain Missed Result
29 0 1 0 Passed

@wesbland wesbland added the passed final vote Passed the final formal vote label Dec 8, 2020
@wesbland wesbland closed this as completed Jan 6, 2021
MPI 4.0 Ratification automation moved this from Ready to Merge to Done Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chap-topologies Process Topologies Chapter Committee errata Errata items for the previous MPI Standard passed final vote Passed the final formal vote
Projects
No open projects
Development

No branches or pull requests

5 participants