Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topologies Chapter RC Review Issues #353

Closed
2 tasks done
wesbland opened this issue Nov 25, 2020 · 4 comments
Closed
2 tasks done

Topologies Chapter RC Review Issues #353

wesbland opened this issue Nov 25, 2020 · 4 comments
Assignees
@tonyskjellum @cniethammer @RolfRabenseifner @GuillaumeMercier @cblaas
Labels
chap-topologies Process Topologies Chapter Committee Chapter Committee Change Changes to be made by the respective chapter committee(s)
Projects
MPI 4.0 Ratification
Milestone
2020-12

Comments

@wesbland
Copy link
Member

wesbland commented Nov 25, 2020 •
edited by RolfRabenseifner
Loading

Problem

Raised by @hritzdorf:

  • Page 441: Page number 401:
    Lines 9-10: unnecessary line break before coords

  • Page 442: Page Number 402: (I don’t know whether this is intended)
    Lines 18-19: edges[index[rank-1]] is split over 2 lines.
@wesbland wesbland added mpi-4.0 chap-topologies Process Topologies Chapter Committee Chapter Committee Change Changes to be made by the respective chapter committee(s) labels Nov 25, 2020
@wesbland wesbland added this to the 2020-12 milestone Nov 25, 2020
@wesbland wesbland added this to Triage in MPI 4.0 Ratification via automation Nov 25, 2020
@cniethammer
Copy link

The line break on page 441/401 line 9-10 seems intentionally to me. The same text is used at other places in a separate paragraph, too. Also, there is a special %mansplit mark in the tex source at this place.

The line break on page 442/402 line 18-19 seems accidental and \gb or \vlgb are not doing a good job here. I would go for an \mbox here...

@wgropp
Copy link

wgropp commented Dec 1, 2020

The line break on 442/402 line 18-19 is not the best but acceptable. If breaking the expression across a line is not desired, it is better to put this in display mode. I'm going to leave these as is.

@wesbland wesbland moved this from Triage to To Do for MPI 4.0 in MPI 4.0 Ratification Dec 7, 2020
@RolfRabenseifner RolfRabenseifner mentioned this issue Dec 21, 2020
Closed
37 tasks
@wesbland
Copy link
Member Author

wesbland commented Jan 8, 2021

@RolfRabenseifner This also needs to be double checked with #405.

@RolfRabenseifner
Copy link

RolfRabenseifner commented Jan 13, 2021 •
edited
Loading

All resolved in Issue #405

MPI 4.0 Ratification automation moved this from To Do for MPI 4.0 to Done Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyskjellum tonyskjellum

@cniethammer cniethammer

@RolfRabenseifner RolfRabenseifner

@GuillaumeMercier GuillaumeMercier

@cblaas cblaas

Labels
chap-topologies Process Topologies Chapter Committee Chapter Committee Change Changes to be made by the respective chapter committee(s)
Projects
No open projects
MPI 4.0 Ratification
Done
Milestone
2020-12
Development

No branches or pull requests
7 participants
@tonyskjellum @wesbland @cniethammer @RolfRabenseifner @GuillaumeMercier @wgropp @cblaas