Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for RC 40 as discussed at the MPI forum Dec 7-10, 2020 for Chapters 1, 2, 8, 16-18, A, B & others #405

Closed
35 of 37 tasks
RolfRabenseifner opened this issue Dec 12, 2020 · 22 comments
Assignees
Labels
chap-backward Backward Compatibility Chapter Committee chap-bindings-summary Language Bindings Summary Chapter Committee chap-changelog Changelog Chapter Committee chap-deprecated Deprecated Functions Chapter Committee chap-removed Removed Interfaces Chapter Committee chap-terms MPI Terms and Conventions Chapter Committee chap-topologies Process Topologies Chapter Committee Chapter Committee Change Changes to be made by the respective chapter committee(s)

Comments

@RolfRabenseifner
Copy link

RolfRabenseifner commented Dec 12, 2020

Problem

Summary of all changes reported by the reviewers for mainly Chapters 2, 8, 16-18, A, B and summarized in the attached pdf.

Proposal

As voted on the RC 40, the changes shall be stored inseveral related pull requests

Changes to the Text

See pdf and pull requests

Latest commented pdf with all changes from MPI-4.0 RC-1 (Dec. 2020) to RC-2 (Feb. 2021)
that are related to this issue:

mpi40-rc-feb-21_rab.pdf
and especially for PR547 MPI_Sessions_finalize: mpi40-issue435-PR547-sessions-2021-FEB-26-v1.pdf

List of latest pull requests that should be added to MPI-4.0 RC 2:

Both, base PR and update PR not yet voted in:

  • PR528 to be updated with PR534 - in Chap. 2 Terms
  • PR484 to be updated with PR533 - in Chap. 7 Groups, Contexts
  • PR434 to be updated with PR544 - in Chap. 18 Semantic changes (formerly Backward incompatibilities) (+ not updated Chap. 19 and Annex B)
  • PR444 to be updated with PR528 - in Annex A.1
  • PR455 to be updated with PR425 and PR540 - in Chap. 14 I/O (changes by Tony)

For the following updates, the base is already voted in:

  • PR351 to be updated with PR531 - in Chap. 5 Datatypes
  • PR429 to be updated with PR529 - in Annex B Change-Log
  • (PR412) to be updated with PR530 - in Chap. 19 Language Bindings
  • Issue 341 to be updated with PR532 - in Chap. 6 Collectives

Additional changes also reported in the pdf

  • Issue 437 to be updated with PR517 - in Chap. 4 Partitioned Communication
    (Additional question: is MPI_Parrived required to make progress? Answer from the Forum meeting Feb.2021: YES and change name to MPI_Ptest)

  • Issue 435 to be updated with PR547 - in Chap. 11.3 Sessions Model

Impact on Implementations

None - all are corrections to the latex text only to remove errors or inconsistencies.

Impact on Users

None.

Open, merged, and other issues/PR related to this issue 405

In the latest commented pdf (see below), the following open issues are reported (see "#-TODO" and "Done" comments in the pdf):

Related Pull Requests from other authors (see also "#-TODO" and "Done" comments in the latest commented pdf below):

See also "#-TODO" and "Done" comments in the latest version of the commented mpi-4-rc pdf file:
mpi40-rc-nov-20_rab_Chap-8+16+17+A+B_update14.pdf

References

@RolfRabenseifner RolfRabenseifner self-assigned this Dec 12, 2020
@RolfRabenseifner RolfRabenseifner added chap-backward Backward Compatibility Chapter Committee chap-changelog Changelog Chapter Committee chap-deprecated Deprecated Functions Chapter Committee chap-removed Removed Interfaces Chapter Committee chap-topologies Process Topologies Chapter Committee Chapter Committee Change Changes to be made by the respective chapter committee(s) mpi-4.0 labels Dec 12, 2020
@RolfRabenseifner RolfRabenseifner added this to Triage in MPI 4.0 Ratification via automation Dec 12, 2020
@RolfRabenseifner RolfRabenseifner moved this from Triage to To Do for MPI 4.0 in MPI 4.0 Ratification Dec 12, 2020
@RolfRabenseifner RolfRabenseifner added chap-bindings-summary Language Bindings Summary Chapter Committee chap-terms MPI Terms and Conventions Chapter Committee labels Dec 12, 2020
@cblaas cblaas mentioned this issue Dec 18, 2020
43 tasks
@RolfRabenseifner
Copy link
Author

RolfRabenseifner commented Dec 19, 2020

The "no more 30 character limit for MPI identifiers" is done. See Sections 2.2, 18.1, 19.1.5 page 791 Table 19.1 2B and page 793f 2nd advice to impl., B.1.2 Items 1 and 33, in following pdf:

It also includes all rc-40 updates to the change-log chapter.

Current implementation status is reported in

@RolfRabenseifner
Copy link
Author

RolfRabenseifner commented Dec 21, 2020

All changes by PR 439 are checked and verified in
mpi40-report_Issue405_PR439.pdf
PR 439 includes and superseeds the old PR 332. (PR332 was therefore closed.)

( mpi40-rc-nov-20_rab_Chap-8+16+17+A+B_update3.pdf
is based on the RC40 document and contains comments about the changes of this PR 439 in Chapter 8.
)

@RolfRabenseifner
Copy link
Author

RolfRabenseifner commented Dec 22, 2020

All changes by PR 441 (removed.tex) are checked and verified in
mpi40-report_Issue405_PR441.pdf

@RolfRabenseifner
Copy link
Author

All changes by PR 442 (deprecated.tex) are checked and verified in
mpi40-report_Issue405_PR442.pdf

@RolfRabenseifner
Copy link
Author

RolfRabenseifner commented Dec 22, 2020

All changes by PR 443 (misc-2.tex - the info chapter) are checked and verified in
mpi40-report_Issue405_PR443.pdf

@RolfRabenseifner
Copy link
Author

All changes by PR 444 (appLang-Const.tex - the Annex A.1) are checked and verified in
mpi40-report_Issue405_PR444.pdf

@RolfRabenseifner
Copy link
Author

RolfRabenseifner commented Jan 5, 2021

All changes by PR 449 (mainly callback references) are checked and verified in
mpi40-report_Issue405_PR449_v02.pdf

@RolfRabenseifner
Copy link
Author

All changes by PR 449 (mainly callback references, including a late footnote number correction in terms) are checked and verified in
mpi40-report_Issue405_PR449_v03.pdf

@RolfRabenseifner
Copy link
Author

All changes by PR 461 (completing the change-log) are checked and verified in
mpi40-report_Issue405_PR461_v05.pdf

It contains only small additional sentences, see pages 1040-1042. They are the basis for completing the index sections that nearly all new constants, types, callbacks and functions have a reference to the page of their change-log item.

@RolfRabenseifner
Copy link
Author

Thank you Wesley for your help to fix the problem with github and binding-2.tex in PR449.
The corrected pdf is now:
mpi40-report_Issue405_PR449_v05.pdf

@RolfRabenseifner
Copy link
Author

All ``_c'' in \code{...} - latest pdf of PR499:
mpi40-report_Issue405_PR499_v09.pdf

@RolfRabenseifner
Copy link
Author

Latest pdf for PR493: mpi40-report_Issue405_PR493_v04.pdf

@RolfRabenseifner RolfRabenseifner changed the title Changes for RC 40 as discussed at the MPI forum Dec 7-10, 2020 for Chapters 2, 8, 16-18, A, B & others Changes for RC 40 as discussed at the MPI forum Dec 7-10, 2020 for Chapters 1, 2, 8, 16-18, A, B & others Jan 23, 2021
@wgropp
Copy link

wgropp commented Jan 24, 2021

Is there a PR for any remaining issues? If not, can this be closed?

@RolfRabenseifner
Copy link
Author

Is there a PR for any remaining issues? If not, can this be closed?

@wgropp I'm not sure, because https://github.com/mpi-forum/mpi-standard/pull/476 did not show a pdf. Therefore, I could not check whether the MPI_Xxxx declarations in A.3 and A.4 are now again with hyperrefs to their main (i.e. first underlined) page in the Declarations Index.
Therefore the checkbox

is still not checked.
This is the last remaining checkbox before I can close this issue. (Independent of that, I still need to update my report of changes.)

@wgropp
Copy link

wgropp commented Jan 25, 2021

I believe these links are present; I see them for both the functions and MPI types.

@RolfRabenseifner RolfRabenseifner moved this from In Progress to Done in MPI 4.0 Ratification Jan 25, 2021
@RolfRabenseifner
Copy link
Author

All pull requests are merged. Therefore, I close this issue 405.

MPI 4.0 Ratification automation moved this from Done to Triage Feb 24, 2021
@RolfRabenseifner RolfRabenseifner moved this from Triage to In Progress in MPI 4.0 Ratification Feb 24, 2021
@RolfRabenseifner
Copy link
Author

Reopened for the PRs from the Feb 2021 meeting, see first part of the description of this issue.

@wesbland
Copy link
Member

@RolfRabenseifner I believe all of the tasks remaining in this issue have moved into their own issues so I'm going to close this. If that's not true, can you create issues for anything left?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chap-backward Backward Compatibility Chapter Committee chap-bindings-summary Language Bindings Summary Chapter Committee chap-changelog Changelog Chapter Committee chap-deprecated Deprecated Functions Chapter Committee chap-removed Removed Interfaces Chapter Committee chap-terms MPI Terms and Conventions Chapter Committee chap-topologies Process Topologies Chapter Committee Chapter Committee Change Changes to be made by the respective chapter committee(s)
Projects
None yet
Development

No branches or pull requests

3 participants