Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit the use of return code vs. error class in MPI_T #426

Closed
schulzm opened this issue Jan 10, 2021 · 4 comments
Closed

Revisit the use of return code vs. error class in MPI_T #426

schulzm opened this issue Jan 10, 2021 · 4 comments
Assignees
Labels
mpi-4.1 For inclusion in the MPI 4.1 standard wg-tools Tools Working Group
Projects

Comments

@schulzm
Copy link

schulzm commented Jan 10, 2021

Problem

When we introduced the MPI_T interface in MPI 3.0, we decided to use return codes for all MPI_T functions instead of error classes, to allow continued operation on error and to enable the usage before Init. With recent changes this may be obsolete.

Proposal

Change occurrences of error code to return code to make clear that these return codes behave differently from the "usual" MPI return codes.

Changes to the Text

See PR#646

Impact on Implementations

Should be none.

Impact on Users

Should be none, except for consistency - possible better usage of error handling.

References

@mahermanns
Copy link
Member

@schulzm The introduction of this issue suggests this to be very close to this one: #385 and could be a duplicate.

So the 4.1 part of handling return codes should probably discussed there, and this issue is more about fixing the language/typo? Is that already fixed by some other PR?

@wesbland wesbland added the mpi-4.1 For inclusion in the MPI 4.1 standard label Jan 11, 2021
@wesbland wesbland added this to To Do in MPI 4.1 Jun 9, 2021
@schulzm schulzm added the wg-tools Tools Working Group label Jul 21, 2021
@mahermanns
Copy link
Member

This might be a duplicate of #385 or should at least be handled in the same way.

@mahermanns
Copy link
Member

Tools WG, Dec 2, 2021: We favor to keep the current semantics but maybe make it clearer in the text that MPI_T behaves different than the rest of MPI. The text should rather talk about "MPI_T error codes" to make the difference clear to the user.

@mahermanns
Copy link
Member

Let's close this as a duplicate of #542 and continue discussion there.

MPI 4.1 automation moved this from To Do to Merged Aug 25, 2022
@wesbland wesbland closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mpi-4.1 For inclusion in the MPI 4.1 standard wg-tools Tools Working Group
Projects
No open projects
MPI 4.1
Merged
Status: Done
Development

No branches or pull requests

3 participants