Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct usage of the terms error and return codes in the tools chapter #542

Closed
schulzm opened this issue Feb 15, 2022 · 5 comments
Closed
Assignees
Labels
chap-tools Tools Chapter Committee had reading Completed the formal proposal reading mpi-4.1 For inclusion in the MPI 4.1 standard passed final vote Passed the final formal vote passed first vote Passed the first formal vote wg-tools Tools Working Group
Milestone

Comments

@schulzm
Copy link

schulzm commented Feb 15, 2022

Problem

The MPI_T interface doesn't use error codes in the typical MPI sense, but rather return codes that are benign and do not invoke error handler. In some areas the language was unclear about this - this ticket fixes this.

Proposal

Minor changes around error/return codes in the tools chapter.

Changes to the Text

See PR #795

Impact on Implementations

None

Impact on Users

Clarification in the standard

References and Pull Requests

Issue 426
Issue 385

Old PR: https://github.com/mpi-forum/mpi-standard/pull/646

@schulzm
Copy link
Author

schulzm commented Oct 30, 2022

I made a pass and updated the PR - I think one of the issues was "behaves like MPI error classes" when we just meant it has to fit the range. I tried to fix this - please review

@mahermanns
Copy link
Member

I made a pass and updated the PR - I think one of the issues was "behaves like MPI error classes" when we just meant it has to fit the range. I tried to fix this - please review

I agree with your assessment of the original intent. I left some minor comments on the PR.

@mahermanns mahermanns added this to the December 2022 milestone Oct 31, 2022
@wesbland wesbland added Chapter Committee Change Changes to be made by the respective chapter committee(s) and removed Chapter Committee Change Changes to be made by the respective chapter committee(s) labels Nov 9, 2022
@wesbland wesbland added the scheduled reading Reading is scheduled for the next meeting label Nov 17, 2022
@wesbland wesbland added the had reading Completed the formal proposal reading label Dec 6, 2022
@mahermanns
Copy link
Member

After discussion during the December meeting, we should provide term index entries for return code.

@wesbland wesbland modified the milestones: December 2022, February 2023 Jan 17, 2023
@wesbland wesbland added no-no Requires a no-no vote scheduled vote labels Jan 17, 2023
@wesbland wesbland removed the no-no Requires a no-no vote label Feb 1, 2023
@wesbland wesbland added the passed first vote Passed the first formal vote label Feb 8, 2023
@wesbland
Copy link
Member

wesbland commented Feb 8, 2023

This passed a first vote on 2023-02-08.

Yes No Abstain
27 0 4

@wesbland wesbland modified the milestones: February 2023, March 2023 Mar 1, 2023
@wesbland wesbland removed the scheduled reading Reading is scheduled for the next meeting label Mar 1, 2023
@mpiforumbot
Copy link

This passed a 2nd vote.

Yes No Abstain
30 0 1

@mpiforumbot mpiforumbot added the passed final vote Passed the final formal vote label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chap-tools Tools Chapter Committee had reading Completed the formal proposal reading mpi-4.1 For inclusion in the MPI 4.1 standard passed final vote Passed the final formal vote passed first vote Passed the first formal vote wg-tools Tools Working Group
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants