dlpack: Update to DLPack v1.0 and Python array API v2023.12 #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalcinl
force-pushed
the
update/dlpack-v1.0
branch
from
d629cba
to
8e8d6ec
Compare
dalcinl
commented
May 5, 2024
dalcinl
force-pushed
the
update/dlpack-v1.0
branch
from
8e8d6ec
to
5207af7
Compare
|
@leofang Are you aware of any other consumer implementation for v1.0, or am I the first to sail this boat? |
dalcinl
force-pushed
the
update/dlpack-v1.0
branch
from
5207af7
to
8dc726d
Compare
dalcinl
commented
May 10, 2024
dalcinl
force-pushed
the
update/dlpack-v1.0
branch
from
8dc726d
to
f8c6763
Compare
|
Sorry for delay, looks good to me for a quick read. Do you want to merge this now or wait for NumPy/CuPy to catch up? |
I'm really thinking on merging it and finally making new release as soon as possible. Do you agree? |
|
Sure, fine with me. I need to squeeze time to implement it for CuPy... |
dalcinl
force-pushed
the
update/dlpack-v1.0
branch
from
f8c6763
to
a85c172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References