Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update example app react native version #82

Merged
merged 7 commits into from
May 18, 2023

Conversation

brainbicycle
Copy link
Contributor

Updates react native in the example app from 0.67.4 to 0.69.10
https://react-native-community.github.io/upgrade-helper/?from=0.67.4&to=0.69.10

I was having trouble running the example in Xcode 14.3 with react native upgraded it runs again :)

Runs on my machine for both iOS and Android but maybe someone else wants to give it a shot:

android-ios

Let me know if you want anything changed or it looks like I missed anything!

// quick workaround solution for issue with symlinked modules ref:
// https://github.com/brodybits/create-react-native-module/issues/232
watchFolders: ['.', '..']
watchFolders: [path.resolve(__dirname, '.'), path.resolve(__dirname, '..')],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unrelated to react native change but watchman was not working with the relative paths, this fixed it for me

Copy link
Owner

@mpiannucci mpiannucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Thank you!!!

@mpiannucci mpiannucci merged commit c69117d into mpiannucci:main May 18, 2023
@brainbicycle brainbicycle deleted the brian/update-example-react-native branch May 18, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants