Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up rshiny app #19

Merged
merged 22 commits into from Mar 18, 2021
Merged

Clean up rshiny app #19

merged 22 commits into from Mar 18, 2021

Conversation

zyzzyxdonta
Copy link
Contributor

@zyzzyxdonta zyzzyxdonta commented Feb 9, 2021 •
edited

I fixed and changed a couple of things. This is what the app looks like now:
Screenshot_2021-03-02 gearshifft Benchmark Analysis Tool

@zyzzyxdonta
Only single definition of tags and regexes
8fba340
@zyzzyxdonta
Remove == T and == F
154d622
@zyzzyxdonta
Define and use operator %!in% as negation of %in%
70ae6ff
@zyzzyxdonta
Remove redundant ifelse
ec0f86d
@zyzzyxdonta
Add page title in browser window/tab
6a75c0c
@zyzzyxdonta
Fix using simplex theme
98f131d
@zyzzyxdonta
Call tags$...() functions instead of using inline HTML
8384e7c
@zyzzyxdonta
Move unordered lists out of paragraphs using tagList
7799bb3
@zyzzyxdonta
Get rid of unneeded div
7d49387
@zyzzyxdonta
Don't print paragraphs in bold
31daac9
@zyzzyxdonta
Remove additional styling that has no/almost no effect
b487802
@zyzzyxdonta
Add missing column inside fluidRow
9c557af
@zyzzyxdonta
Replace redundant fluidRow with tagList
9a6805e
@zyzzyxdonta
Replace leading br() in tabPanel with padding-top for .tab-content
e07badb
@zyzzyxdonta
Remove opening br() in wellPanel()
61baf18
@zyzzyxdonta
Various formatting and capitalization
5ab4309
@zyzzyxdonta
Remove code duplications in table generation for Info tab
0e58dde
@zyzzyxdonta
Replace br() after plot with margin-bottom for .shiny-plot-output
2cde1d3
@zyzzyxdonta zyzzyxdonta marked this pull request as ready for review March 2, 2021 11:22
@zyzzyxdonta zyzzyxdonta marked this pull request as draft March 11, 2021 09:11
@zyzzyxdonta zyzzyxdonta changed the title Refactor rshiny app Clean up rshiny app Mar 12, 2021
@zyzzyxdonta zyzzyxdonta marked this pull request as ready for review March 12, 2021 12:33
@zyzzyxdonta
Copy link
Contributor Author

@psteinb can you have a look at this? I did a bit of fixing and cleanup in the code and added a filter preset that always shows some data when first opening the app.

psteinb
psteinb approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@psteinb psteinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this contribution!

@psteinb psteinb merged commit a6367df into mpicbg-scicomp:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteinb psteinb psteinb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zyzzyxdonta @psteinb