GHC 9.2.1 support #116
Merged
GHC 9.2.1 support #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Focused on getting it to compile, by commenting out operational parts lavishly. The assumption is GHC 9.2.1 only, a new version, as the concept of separate annotations is now gone. These will be brought back while working through tests.
23 out of 448 tests failed Much easier now that I can use HLS
Down to 17 failing tests
But I think NegApp needs work
Down to 11 failures
Down to 7 test failures
lambda42.hs Structure7.hs
|
With a modified ghc-exactprint at version 1.5.0 this branch now compiles and passes tests for GHC 9.2.1 |
This was referenced Feb 1, 2022
|
Should I expect hlint to pass? |
|
@alanz No need to fix HLint for now. Besides HLint there's some other cleanup we can do but I'm happy to do them after merging this. |
@alanz What do you think? It appears so, but I'm not very up to date wrt GHC 9.2 stuff and I'm not sure whether Alan thinks it's ready to merge. I'll merge it if Alan doesn't respond in the next few days. |
|
I think it is ready to be merged. And has been for ages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focused on getting it to compile, by commenting out operational parts
lavishly.
The assumption is GHC 9.2.1 only, a new version, as the concept of
separate annotations is now gone.
These will be brought back while working through tests.