Add compatibility for GHC 9.0 and 9.2 #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be great make haskell gha download the ghc-9.2 prerelase to test it in ci (maybe it is possible? ghcup can install the ghc prerelase and gha uses ghcup under the hood) |
|
Related: haskell/actions#55 I would like to avoid implementing custom support, so I would wait for this feature to be implemented. |
Closed
jneira
approved these changes
Jul 29, 2021
jneira
changed the title
|
@fendor could we get a hackage release with 9.0 support? thanks! |
This was referenced Aug 26, 2021
berberman
reviewed
Aug 29, 2021
Comment on lines
+415
to
+426
| #if __GLASGOW_HASKELL__ >= 902 | ||
| -- Copied from GHC, do we need that? | ||
| addWay' :: Way -> DynFlags -> DynFlags | ||
| addWay' w dflags0 = | ||
| let platform = targetPlatform dflags0 | ||
| dflags1 = dflags0 { targetWays_ = Platform.addWay w (targetWays_ dflags0) } | ||
| dflags2 = foldr setGeneralFlag' dflags1 | ||
| (Platform.wayGeneralFlags platform w) | ||
| dflags3 = foldr unSetGeneralFlag' dflags2 | ||
| (Platform.wayUnsetGeneralFlags platform w) | ||
| in dflags3 | ||
| #endif |
There was a problem hiding this comment.
IIRC, we don't need this in later GHC versions, as we can use GHC.Driver.Session.setDynamicNow directly.
fendor
added a commit
to fendor/hie-bios
that referenced
this pull request
Aug 30, 2021
* Make hie-bios compile with GHC-HEAD * Adapt hie-bios to compile with GHC HEAD * Add allow-newer to get a build plan * Bump up ghc upper bound * Update ghc head to 9.0 * Use ghc-api-compat head * Adjust some defs to 9.0.1 * Add ghc-api-compat to exe component * Remove updated libraries * Fix some definitions * Add compatibility for GHC 9.2 Co-authored-by: jneira <atreyu.bbb@gmail.com> (cherry picked from commit 3703788)
fendor
added a commit
to fendor/hie-bios
that referenced
this pull request
Aug 30, 2021
* Make hie-bios compile with GHC-HEAD * Adapt hie-bios to compile with GHC HEAD * Add allow-newer to get a build plan * Bump up ghc upper bound * Update ghc head to 9.0 * Use ghc-api-compat head * Adjust some defs to 9.0.1 * Add ghc-api-compat to exe component * Remove updated libraries * Fix some definitions * Add compatibility for GHC 9.2 Co-authored-by: jneira <atreyu.bbb@gmail.com> (cherry picked from commit 3703788)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids dependency on
ghc-api-compatso thathie-bioscan actually be uploaded to Hackage.Additionally, moves
parseTargetFilestoGap.hssince GHC 9.2 exposes the function we want 馃帄.supersedes #285