Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Scatter + tests #102

Merged
merged 42 commits into from
Sep 13, 2020
Merged

add Scatter + tests #102

merged 42 commits into from
Sep 13, 2020

Conversation

ianhi
Copy link
Collaborator

@ianhi ianhi commented Sep 4, 2020 •
edited
Loading

  • docstring
  • example page (still needs gifs)
  • example notebook
  • gallery entry
  • reliming behavior
  • use plot when c and s do not vary
  • if c is a 2d array of numbers don't error
  • scatter tests
  • add a cache to not call functions over and over
  • labels
    also:
  • created tests + testing infrastructure (github actions)
  • autoformatted using black
  • started to introduce broadcasting make interactive_plot args act as broadcastable versions of pyplot.plot arguments #106

@ianhi
Copy link
Collaborator Author

ianhi commented Sep 4, 2020

continuation of #101 but ended up opening a new one in the quest to get github actions to go

@ianhi ianhi mentioned this pull request Sep 4, 2020
Closed
@ianhi
Copy link
Collaborator Author

ianhi commented Sep 8, 2020

heatmap slicer test failure between 3.2 and 3.3 is due to different behavior. idk how to effectively differentiate at test time though??

@ianhi ianhi mentioned this pull request Sep 8, 2020
Open
12 tasks
@ianhi
mpl 32 version of heatmap slicer
4b8f2a5
@ianhi
account for differences in matplotlib versions
d3f93fc
@ianhi
appease the formatter
ae3afbb
@ianhi
break tests and formatting checks apart
b8aa502
@ianhi
add pre-commit
5f623ef
@ianhi
update dev install instructions
35aa2f0
@ianhi
create datalim updates as helper methods
6604a57 
they even ratchet!
@ianhi
add stretching to scatter
e3d7b39
@ianhi
add tests for updating datalims
199da6a
@ianhi
attempt to restore github workflows
a00bb27
@ianhi
resuscitate readthedocs
61e9284
@ianhi
create broadcasting helper functions
db6cbd2 
Basically a nightmarish reimplementation of a subset of numpy broadcasting. Reimplemented such that it only considers the first axis and allows the other axes to match
@ianhi
scatter takes x,y and broadcasts
0d4b6c4
@ianhi
create wealth of nations example
4c29574
@ianhi
fix broadcasting for colors
c1a3942
@ianhi
cache broadcasted function calls
9268867 
this way we don't unnecessarily call broadcasted functions multiple times
@ianhi
add label support to scatter
29e9261
@ianhi
interactive scatter example notebook
4e1a27e
@ianhi
scatter plot docs
24fa93f
@ianhi
Copy link
Collaborator Author

ianhi commented Sep 13, 2020

Gonna merge because it's getting hard to implement other things without the improvements in this pr

@ianhi ianhi merged commit 1cb0ad2 into master Sep 13, 2020
@ianhi ianhi deleted the scatter branch September 25, 2020 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ianhi