fix: support ipywidget sliders in save_animation

[redeboer]

Closes #181

These are the changes required to get the snippet from #181 to work. Feel free to close this PR if it has any undesired consequences or does not comply with the design of the package.

[ianhi]

Ok I've thought about this a little bit more. I think the underlying issue is that I lumped the test for being ipywidgets together with the test for if it was automatically created. This is leading to you duplicating the N,min_... code. I think a more reasonable flow would be:

# test if this is an autogenerated slider
if "Box" in str(slider...)
    # loop over children of the box
          slider =  ....

if not _not_ipython and isinstance(slider, [FloatSlider, IntSlider):
   ...
elif isinstance(slider, mSlider):
   ...

Would you mind changing the implementation to be like that? (Or convince me that something else is better!)

[ianhi]

I took the liberty of adding a test with mixed slider types to make sure that they all work.

[redeboer]

#182 (comment)
Ah perfect, thanks!

#182 (review)
I made this of it now bf85263, but it's not perfect. Could be this is related to the abstract slider idea described in #183. If slider here
https://github.com/ianhi/mpl-interactions/blob/ef9b0a9c83983f94ead50aa3e36a54314d76e63b/mpl_interactions/controller.py#L276
had some common interface with a min, max, and step, that could simplify the code here. But for now, hope this suffices.

[ianhi]

oooh hooray the tests caught that! they are good for something 🎉

[ianhi]

Thanks @redeboer ! I'll make a new release shortly.

@all-contributors please add @redeboer for code and userTesting

[allcontributors]

@ianhi

I've put up a pull request to add @redeboer! 🎉