Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a babel build task for front usage with any cjs module loader #6

Closed
wants to merge 1 commit into from

Conversation

youknowriad
Copy link

This is a small PR that adds a task to build an ES5 version before publishing the module. This allows browser usage using any cjs module loader.

What do you think ?

Thanks

@youknowriad youknowriad mentioned this pull request Jun 1, 2016
@youknowriad
Copy link
Author

This requires the ES5 client to load "babel-polyfill"

@mplatt
Copy link
Owner

mplatt commented Jun 7, 2016

Thanks @youknowriad but tis is not where I would like to go with this, I would like to keep it ES6. Basically you could wrap this in a project with a babel task should you really require ES6 support with 3.*. But for your use case 2.0.2 might be most appropriate. I'm gonna update the readme to give some pointers on this.

@mplatt mplatt closed this Jun 7, 2016
@youknowriad
Copy link
Author

@mplatt I totally understand no worry.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants