Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new @Singular annotation for @Builder collection fields #77

Closed
jkwatson opened this issue Feb 14, 2015 · 29 comments
Closed

Support new @Singular annotation for @Builder collection fields #77

jkwatson opened this issue Feb 14, 2015 · 29 comments
Assignees
Milestone

Comments

@jkwatson
Copy link

Would love to have this; This is a great new feature in lombok, and IDEA support would be awesome!

@ghost
Copy link

ghost commented Feb 17, 2015

+1.

@bpedman
Copy link

bpedman commented Feb 19, 2015

+1

@mplushnikov mplushnikov self-assigned this Feb 22, 2015
@mplushnikov mplushnikov added this to the 0.10.0 milestone Feb 22, 2015
@timschlechter
Copy link

+1

7 similar comments
@pawelkrupinski
Copy link

+1

@tleveque23
Copy link

+1

@zshamrock
Copy link

+1

@pkoperek
Copy link

+1

@mragab
Copy link

mragab commented Mar 17, 2015

+1

@RodrigoQuesadaDev
Copy link

+1

@j-walker23
Copy link

+1

@j-walker23
Copy link

Can anyone here explain how to add this manually for now, please?

@jordanjennings
Copy link

Even though it's not fully supported by the plugin, you can actually use
the annotation and the generated method in your code. It won't autocomplete
the method name, so you'll have to manually type it and It'll show up in
red while editing the file, but your code will still run. That's been my
experience using it so far anyway.

On Tue, Apr 7, 2015 at 1:15 PM, John Walker notifications@github.com
wrote:

Can anyone here explain how to add this manually for now, please?


Reply to this email directly or view it on GitHub
#77 (comment)
.

@j-walker23
Copy link

Hey, thanks for your response, appreciate it. I should have worded my question in a way that actually made sense.

What i wanted to ask is if there is a way to manually add that part, really meaning just duplicate what the builder is doing so all of the pseudo errors you mentioned won't show up. And so my colleagues don't lose their minds : )

@j-walker23
Copy link

I just ended up writing a custom one. Using the other awesome annotations i was able to write the builder with @Singular functionality with very little code. Thanks lombok and plugin people!

@RodrigoQuesadaDev
Copy link

+1

1 similar comment
@beihaifeiwu
Copy link

+1

@jkwatson
Copy link
Author

@j-walker23 Are you saying you have changes to the plugin that make it work? Or a separate plugin? Either way, I'm sure a pull request with the changes to this project would be greatly appreciated!

@dnoggle
Copy link

dnoggle commented Apr 15, 2015

+1

@j-walker23
Copy link

@jkwatson I wish i was saying that. I ended up just writing the class manually, but with using 20 other lombok annotations it really ended up being very short anyway.

I am a big time Java noob and am forced into doing full stack because all of our backend devs left. I wouldn't even know where to start with a PR. If i was that cool you guys would be the first to know!

@WonderCsabo
Copy link

👍

@dnnoggle
Copy link

dnnoggle commented May 5, 2015

Is there any rough planned date for 0.10.0?

@mrcritical
Copy link

+1

1 similar comment
@rcoedo
Copy link

rcoedo commented May 26, 2015

+1

mplushnikov pushed a commit that referenced this issue Jun 21, 2015
mplushnikov pushed a commit that referenced this issue Jun 21, 2015
mplushnikov pushed a commit that referenced this issue Jun 21, 2015
added validation of @Singular Field Type
mplushnikov pushed a commit that referenced this issue Jun 21, 2015
added test class data from lombok project
@spencergibb
Copy link

+1

mplushnikov pushed a commit that referenced this issue Jun 28, 2015
added more validation for @Singular
@mplushnikov
Copy link
Owner

The version 0.9.5 already contains initial support for @Singular. Please verify the functionality.

@dnoggle
Copy link

dnoggle commented Jun 30, 2015

@Singular works and so does importing the builder nested class.

Thank you!

@jkwatson
Copy link
Author

Looks and works great! Thanks!

@sunguangran
Copy link

+1

@spencergibb
Copy link

👍 worked great!

@mplushnikov mplushnikov modified the milestones: 0.9.6, 0.10.0 Jul 7, 2015
mplushnikov pushed a commit that referenced this issue Jul 14, 2015
#77
improved delombok code generation for @Singular Builder (generic parameters)
mplushnikov pushed a commit that referenced this issue Jul 14, 2015
#77
improved delombok code generation for @Singular Builder (build Method and guava collections)
mplushnikov pushed a commit that referenced this issue Jul 14, 2015
#77
improved delombok code generation for @Singular Builder (build Method)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests