-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with Intellij 2020.2 #840
Comments
Error from IntelliJ:
|
There is 0.30 EAP release which should be working under 2020.2, so we shall wait for it become published for non-EAP :) |
It's the same issue as during the 2020.1 release - you need to uninstall the plugin, restart Idea, install lombok plugin 0.30 EAP and it works again. |
@zadam indeed, this bug happened again - thanks a lot! p.s. but yeah, as mentioned later - it will have runtime problems |
It doesn't work on EAP( #821 |
You were using the EAP of IJ 2020.2 |
Same issue with IJ 2020.2 release. Not EAP |
Worked for me w/o needing to uninstall/install, I am able to see 0.30-EAP in plugin list |
How do I add the EAP plugin version to install? |
@Heatmanofurioso just uninstall current plugin, then restart. And install again. Worked for me with IJ 2020.2 release |
It doesn't work properly with IntelliJ Idea 2020.2. com.intellij.diagnostic.PluginException: Element: class de.plushnikov.intellij.plugin.psi.LombokLightMethodBuilder #JAVA because: psi is outdated |
And in fact there are a lot of other issues in IntelliJ regarding the lombok-ized classes. The same error (as above) occurs when trying to see the constructor parameters at the call site. |
Please see: #829 (comment) |
I've fixed this for myself, cloning the project, changing the |
This didn't work for me.
Update This worked for a little bit and then broke again. There are actual issues with the plugin and compatibility with 2020.2. Actual solution is to revert back to 2020.1 until the plugin is updated. Previous This did work. First I uninstalled the version of the plugin installed from the marketplace and restarted IntelliJ. Then, after editing gradle.properties, to build just run To install, open Plugins screen in IntelliJ and click the cog wheel in the menu bar, then "Install Plugin from disk". You can find the built plugin jar under |
That got it working - ok, but are there actually any issues with the plugin? I assume it was set to that version because it hasn't been tested on the new version yet. Let us know if you run into any issues using it with the ~forced upgrade? |
worked for me, thanks note: 0.30-EAP |
As @rupert-madden-abbott updated response states, the plugin still crashes after some time, I've noticed this too. At least the IDE can recognize the generated methods with the forced upgrade. The safe bet for now is to wait for the real fix while using 2020.1. |
i've never worked with IntelliJ plugins, but i think the issue is here. basically, the plugin system will intern the psi elements based on the equality. because this doesn't take into account the if you update the equality check from: it won't de-dupe the two here's the patch:
i uploaded a jar here: Removed Link. This doesn't fix the issue. |
Same problem on my project. |
Wow!!! This is a good contribution. I'm looking forward to see this PR merged and released via market place. |
Any updates on this? It causes the IDEA to be super unhealthy. |
The above patch does not fix my problem. That field in red is decorated with the @Singular annotation. 2020-07-30 09:43:43,838 [ 302652] ERROR - aemon.impl.PassExecutorService - IntelliJ IDEA 2020.2 Build #IU-202.6397.94 AND 2020-07-30 10:21:13,014 [1176606] WARN - Container.ComponentManagerImpl - Class constructor must not have parameters: de.plushnikov.intellij.plugin.settings.ProjectSettingsPage [Plugin: Lombook Plugin] |
Waiting for new version |
The solutions above did not work. Neither reinstalling the plugin again nor replacing the JAR with the modified one. |
Any update to fix the psi problem? |
Here's the update: 60c1f2e |
There are no fix at the moment. One of IntelliJ caches looks like broken. I'm waiting for comming change (Build: 202.7023) from Jetbrains in https://youtrack.jetbrains.com/issue/IDEA-248146 to verify if it fix the problem. |
@mplushnikov thank you for the great work you do man. Already went and left some comments to the JetBrains team. We already support lombok (paypal) but I can't wrap my head as to why they have not made Lombok (and you if you would like) as part of native IDEA. |
@mplushnikov - agree with @carlitorendon , in my company we have one huge repository that uses Lombok extensively and it wouldn't be possible without you. |
I actually started using IntelliJ 2019.3.5 back again since I can't work without Lombok in our company projects and all other solutions for the 2020 version that were suggested didn't solve it for me. |
The plugin works fine for 2020.1, it only breaks with 2020.2. Soon we'll have 2020.2.1 which will probably fix this. |
so lombok can no longer now work on recent Idea ? any idea when this can move on ? |
See: #860 (comment) The .jar on this comment works for me: #840 (comment) |
thanks Sir - will try that and see meanwhile |
The root issue was fixed in IntelliJ core, see: https://youtrack.jetbrains.com/issue/IDEA-248146 #829 #840
IntelliJ IDEA 2020.2.1 RC Build #IC-202.6948.36, built on August 18, 2020 is available and it looks like lombok plugin is working again! |
https://www.jetbrains.com/idea/download 2020.2.1 was released just 2 days back. Is it working now? Please someone confirm. |
It's working for me since Version: 2020.2.1RC. It's seems ok now 🙏 |
@valdemarjuniorr thanks for the quick reply. Will update now. |
) * Consider navigation element in PSI equality checks This seems to solve issues related to psi becoming outdated. Extension of comment by ajchun: mplushnikov/lombok-intellij-plugin#840 (comment) Covers issues: #821, #827, #829, #840, #842, #844, #846, #850, #853, #854, #855, #857 * Remove debug logging related to equality of PsiElements GitOrigin-RevId: e9ad9801b15dc91b872b14add012a9261033fbc7
Short description
Looks like lombok plugin is incompatible with Intellij 2020.2.
Expected behavior
Lombok plugin should work with Intellij 2020.2.
Version information
The text was updated successfully, but these errors were encountered: