Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Builder setterPrefix #719 #736

Merged

Conversation

ocadaruma
Copy link
Contributor

@ocadaruma ocadaruma commented Feb 15, 2020

This PR fixes #719

Hi, thank you for useful plugin.
I added a support for @Builder(setterPrefix). Could you take a look ?

image

@Dikshit-Ram
Copy link

@ocadaruma The build failed. Would you mind looking into it, please?

@ocadaruma
Copy link
Contributor Author

Hm, right...
Let me check

@codecov-io
Copy link

codecov-io commented Feb 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@dadf9a2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #736   +/-   ##
=========================================
  Coverage          ?   69.83%           
  Complexity        ?     1790           
=========================================
  Files             ?      200           
  Lines             ?     6215           
  Branches          ?     1266           
=========================================
  Hits              ?     4340           
  Misses            ?     1266           
  Partials          ?      609           
Impacted Files Coverage Δ Complexity Δ
...j/plugin/action/delombok/DelombokSetterAction.java 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
...llij/plugin/extension/LombokReferenceSearcher.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...plugin/action/delombok/DelombokDelegateAction.java 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
...n/processor/handler/FieldNameConstantsHandler.java 91.46% <0.00%> (ø) 16.00% <0.00%> (?%)
...extension/LombokFieldFindUsagesHandlerFactory.java 75.00% <0.00%> (ø) 3.00% <0.00%> (?%)
...nikov/intellij/plugin/settings/LombokSettings.java 66.66% <0.00%> (ø) 4.00% <0.00%> (?%)
...v/intellij/plugin/quickfix/PsiQuickFixFactory.java 75.00% <0.00%> (ø) 3.00% <0.00%> (?%)
...ndler/singular/SingularGuavaCollectionHandler.java 92.30% <0.00%> (ø) 10.00% <0.00%> (?%)
.../AbstractBuilderPreDefinedInnerClassProcessor.java 82.14% <0.00%> (ø) 12.00% <0.00%> (?%)
.../intellij/plugin/util/PsiAnnotationSearchUtil.java 79.48% <0.00%> (ø) 40.00% <0.00%> (?%)
... and 190 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dadf9a2...bd63b0c. Read the comment docs.

@ocadaruma ocadaruma force-pushed the support-builder-setter-prefix branch 5 times, most recently from 2c4be77 to f6b8b37 Compare February 22, 2020 00:11
@ocadaruma
Copy link
Contributor Author

ocadaruma commented Feb 22, 2020

@mplushnikov Hi, I found that the CI failure of this PR can be solved by disabling cache.

The only difference is 6c30039

Could you clear travis build cache once ?

@mplushnikov
Copy link
Owner

Hello @ocadaruma

thank you very much for your contribution. I'll look on your PR next days!
Can you please add yourself to contributors list from readme.md file?

Copy link
Owner

@mplushnikov mplushnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very well, thank you!

Please only add yourself to the contributors list in the readme.md file

@ocadaruma
Copy link
Contributor Author

Thank you for your quick review !
I added myself to contributors list.

@mplushnikov mplushnikov merged commit 4f2d86d into mplushnikov:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new setterPrefix for Builder
4 participants