(Update on PR #543) Fixed TypeError in LU_comp, updated determinant docs and added rank function for matrices
#610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are test failures. |
|
minor changes to fixe test failures. tests should work now (as you can check here). |
|
sorry, another fix needed in docs. locally I can build docs without failure. |
skirpichev
requested changes
May 17, 2023
vks
reviewed
May 26, 2023
vks
reviewed
May 26, 2023
| @@ -134,6 +134,9 @@ def LU_decomp(ctx, A, overwrite=False, use_cache=True): | |||
| if current > biggest: # TODO: what if equal? | |||
| biggest = current | |||
| p[j] = k | |||
| # without pivot LU fails | |||
| if p[j] is None: | |||
There was a problem hiding this comment.
Is this what happens for the test case A11?
vks
reviewed
May 26, 2023
mpmath/matrices/linalg.py
Outdated
| columns (or rows equivalently). | ||
|
|
||
| Rank is computed via singular value decomposition | ||
| by counting the number of non-zero singular values. |
There was a problem hiding this comment.
Could you please document the iszerofunc parameter, and maybe add an example using it?
There was a problem hiding this comment.
added tests some example for iszerofunc
vks
suggested changes
May 26, 2023
There was a problem hiding this comment.
Looks good from my side, I only had minor additional comments. I agree with @skirpichev's comments.
skirpichev
reviewed
Jun 2, 2023
update imports in test_linalg.py custom `iszerofunc` in rank determination adding rank of matrix via counting eigenvalues form svd_r
skirpichev
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update on PR #543
LU_compwhich raised TypeError on singular matricesdeterminantfunction of matricesrankfunction of matrices(PR #543 was originally opened and closed by sonntagsgesicht)