-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP8 fixes #665
PEP8 fixes #665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok, but please ensure, that these errors are tested in CI. Could you also make commit message more descriptive?
25fc810
to
439b769
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few unrelated changes, but LGTM.
Let's wait few days if someone will object against changes. Code style changes always debatable.
Describe the tool
ruff
, how it finds three pep8 issues, and how it fixes those 3 issues.Ruff supports over 500 lint rules and can be used to replace Flake8 (plus dozens of plugins), isort, pydocstyle, yesqa, eradicate, pyupgrade, and autoflake, all while executing (in Rust) tens or hundreds of times faster than any individual tool.
%
ruff --select=E703,E712,E713 --statistics .
%
ruff --select=E703,E712,E713 --fix .