Drop support for Python versions < 3.8 #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
force-pushed
the
drop-old-py3
branch
3 times, most recently
from
b8bddd2
to
057479e
Compare
skirpichev
changed the title
cbm755
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
Looks reasonable to me, certainly don't see much point supporting before 3.7. Ubuntu 20.04 is on 3.8, and is used in lots of folks containers and this keeps support for that.
There is a burden in supporting old things, even if this still work. For example contributors might use f-strings and not notice until CI fails, thus creating more work.
|
Ok, this a tiny change so far (no code conversion to an incompatible syntax) and could be easily reverted (or partially reverted). Let's merge this. Ping @fredrik-johansson, FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #663