Misc fixes #679
Merged
Misc fixes #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes mpmath#267
Closes mpmath#274
cbm755
approved these changes
Apr 16, 2023
There was a problem hiding this comment.
This looks good to me!
The build packaging dependency probably should've been a different PR: I've never used that before, but I looked it up and it seems reasonable to me.
https://pypi.org/project/build/ <-- "A simple, correct Python build frontend."
| return (self.__rows == other.__rows and self.__cols == other.__cols | ||
| and self.__data == other.__data) | ||
| except AttributeError: | ||
| return NotImplemented |
There was a problem hiding this comment.
I'd not seen this before, but I skimmed https://stackoverflow.com/questions/40780004/returning-notimplemented-from-eq
I also tested this, and confirm that the A9 == None test below.
Closes mpmath#428
cbm755
approved these changes
Apr 16, 2023
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpf('.00')like float constructor does, closes from_str: wrong parsing with underscores after decimal #377