Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setuptools_scm to update __version__ #694

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

skirpichev
Copy link
Collaborator

No description provided.

@skirpichev
Copy link
Collaborator Author

@asmeurer, will you object this change, given the previous history (i.e. #443, #580)?
Keep in mind, that now we don't support py2 and setuptools_scm don't add additional dependencies (it's only in the build-system requirements, just like the versioner).

@asmeurer
Copy link
Contributor

This doesn't appear to do the right thing if I import the local copy of mpmath. It grabs the version from the installed version rather than the version that is actually imported.

Basically, this seems to be assuming that some metadata is in sync with the source, whereas with the version being listed directly like this it's impossible for this issue to occur.

@skirpichev
Copy link
Collaborator Author

skirpichev commented May 10, 2023

This doesn't appear to do the right thing if I import the local copy of mpmath.

Does it make sense to support this kind of workflow? (I guess, the versioneer has same problem.)

This type of workflow could be used for development. But the mpmath has a lot of optional requirements, which are actually required for developers... E.g. pytest or sphinx. In the current docs we suggest do pip install in this case as well. I think it's better: you can create a dedicated virtual environment(s) for the mpmath development, instead of doing system-wide (or per-user) installation of all that stuff.

whereas with the version being listed directly like this

The drawback is some maintenance burden for updating the version... While with the setuptools_scm we could just push a tag. Also, this versioning policy could slightly simplify bug reporting: you can show the mpmath.__version__ and it will be clear which git version you are using.

@skirpichev skirpichev merged commit 16e686d into mpmath:master Feb 23, 2024
8 checks passed
@skirpichev skirpichev deleted the use-setuptools_scm branch February 23, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants