Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify more Postman parameters #443

Merged
merged 8 commits into from
Jan 25, 2019
Merged

Specify more Postman parameters #443

merged 8 commits into from
Jan 25, 2019

Conversation

ewerkema
Copy link
Contributor

@ewerkema ewerkema commented Jan 4, 2019

  • Name and description of Postman collection can be specified.
  • Force the URL facade to include the APP_URL environment variable in the Postman collection

Name and description of Postman collection can be specified
@codecov-io
Copy link

codecov-io commented Jan 4, 2019

Codecov Report

Merging #443 into master will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #443      +/-   ##
============================================
+ Coverage        92%   92.22%   +0.22%     
- Complexity      229      239      +10     
============================================
  Files            11       12       +1     
  Lines           550      566      +16     
============================================
+ Hits            506      522      +16     
  Misses           44       44
Impacted Files Coverage Δ Complexity Δ
src/Commands/GenerateDocumentation.php 94.95% <100%> (-0.7%) 40 <2> (+4)
src/Postman/CollectionWriter.php 89.28% <100%> (+0.39%) 17 <0> (+2) ⬆️
.../Tools/ResponseStrategies/ResponseCallStrategy.php 94.69% <0%> (ø) 38% <0%> (ø) ⬇️
src/Tools/Traits/ParamHelpers.php 100% <0%> (ø) 4% <0%> (?)
src/Tools/Generator.php 94.52% <0%> (+0.72%) 63% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 480bc22...70b159b. Read the comment docs.

The Postman collection currently doesn't use the APP_URL environment variable. This can be forced in the URL Laravel Facade
src/Commands/GenerateDocumentation.php Outdated Show resolved Hide resolved
@shalvah
Copy link
Contributor

shalvah commented Jan 6, 2019

Also, did you check that the UpdateDocumentation command still works?

@ewerkema
Copy link
Contributor Author

ewerkema commented Jan 6, 2019

Also, did you check that the UpdateDocumentation command still works?

I did run it yes, maybe we should also add test cases for the update?

@shalvah
Copy link
Contributor

shalvah commented Jan 7, 2019

Also, did you check that the UpdateDocumentation command still works?

I did run it yes, maybe we should also add test cases for the update?

Yes, please.

@shalvah shalvah merged commit e98c7f4 into mpociot:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants