Patch for ISO and Map display #45
Conversation
README.md
Outdated
| @@ -32,6 +32,9 @@ Country and city lookup: | |||
| $ http ifconfig.co/country | |||
| Elbonia | |||
|
|
|||
| $ http ifconfig.co/iso | |||
There was a problem hiding this comment.
I don't think "iso" is self-explanatory. Can you make the path country-iso?
README.md
Outdated
| @@ -43,6 +46,7 @@ $ http --json ifconfig.co | |||
| { | |||
| "city": "Bornyasherk", | |||
| "country": "Elbonia", | |||
| "isoCountry": "EB", | |||
There was a problem hiding this comment.
Field should follow same naming convention as other fields. Can you make it country_iso?
api/api.go
Outdated
| @@ -84,6 +85,10 @@ func (a *API) newResponse(r *http.Request) (Response, error) { | |||
| if err != nil { | |||
| a.log.Debug(err) | |||
| } | |||
| iso, err := a.oracle.LookupCountryISO(ip) | |||
api/oracle.go
Outdated
| if err != nil { | ||
| return "", err | ||
| } | ||
|
|
index.html
Outdated
| @@ -63,6 +63,10 @@ <h2>Country lookup:</h2> | |||
| <pre> | |||
| $ http {{ .Host }}/country | |||
| {{ .Country }}</pre> | |||
| <h2>Country ISO lookup:</h2> | |||
There was a problem hiding this comment.
Can you make the text "Short country code (ISO 3166-1 alpha-2) lookup"?
index.html
Outdated
| @@ -98,6 +103,13 @@ <h2>Testing port connectivity:</h2> | |||
| "port": 8080, | |||
| "reachable": false | |||
| }</pre> | |||
| {{ end }} | |||
| </div> | |||
| {{ if .IsLookupCityEnabled }} | |||
There was a problem hiding this comment.
Should check that both city and country are not "Unknown".
There was a problem hiding this comment.
Not sure the way I implemented it is the "right" way in Go terms. I decided to check both for having the Country/City Lookup enabled and to check whether any of the two values returns Unknown. I didn't find another way to properly chain the checks, hope it's fine the way I did it.
index.html
Outdated
| </div> | ||
| {{ if .IsLookupCityEnabled }} | ||
| <div class="pure-u-1 pure-u-md-1-1"> | ||
| <h2>MAP</h2> |
|
Thanks! |
Implements #43 and adds a (Static) map display on the page. Hope style and naming convention fit you.