Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring application architecture - remove recursion #6

Closed
mpostol opened this issue Oct 27, 2019 · 3 comments
Closed

Refactoring application architecture - remove recursion #6

mpostol opened this issue Oct 27, 2019 · 3 comments
Assignees
@mpostol
Labels
Architecture 🔀 Architecture Modification In Progress Issue In Progress
Milestone
Imports project f...

Comments

@mpostol
Copy link
Owner

mpostol commented Oct 27, 2019

  • Use dependency injection to remove circular references.
  • Remove reference to Forms to separate project layers.
  • Use composition
  • Use the bootstrapping process to compose and run the application. 
@mpostol mpostol added this to the Backlog milestone Oct 27, 2019
@mpostol mpostol added the In Progress Issue In Progress label Oct 27, 2019
@mpostol mpostol self-assigned this Nov 2, 2019
@mpostol mpostol added the Architecture 🔀 Architecture Modification label Nov 2, 2019
@mpostol mpostol mentioned this issue Nov 2, 2019
Closed
@mpostol
Copy link
Owner Author

mpostol commented Nov 4, 2019

Current state.
Przechwytywanie

mpostol added a commit that referenced this issue Nov 4, 2019
@mpostol
Refactoring application architecture - remove recursion #6
afe6514 
- invalidate: Bootstrapper exception - casting problem #37
- review all comments related to #57 before closing
mpostol added a commit that referenced this issue Nov 4, 2019
@mpostol
Refactoring application architecture - remove recursion #6
fd91fef 
- Removing TreeNode controls from the CAS.UA.Model.Designer.Wrappers to CAS.UA.Model.Designer.Controls
- Created RootTreeNodeControl
- Work in progress
mpostol added a commit that referenced this issue Nov 4, 2019
@mpostol
Refactoring application architecture - remove recursion #6
ced0b3f 
- Removing TreeNode controls from the CAS.UA.Model.Designer.Wrappers to CAS.UA.Model.Designer.Controls
- Created LibraryTreeNodeControl
- Work in progress
mpostol added a commit that referenced this issue Nov 4, 2019
@mpostol
Refactoring application architecture - remove recursion #6
9911efe 
- Removing TreeNode controls from the CAS.UA.Model.Designer.Wrappers to CAS.UA.Model.Designer.Controls
- Created WrapperTreeNodeControl
- Work in progress
mpostol added a commit that referenced this issue Nov 4, 2019
@mpostol
Refactoring application architecture - remove recursion #6
a0684ef 
- Removing TreeNode controls from the CAS.UA.Model.Designer.Wrappers to CAS.UA.Model.Designer.Controls
- Created FolderTreeNodeControl
- Work in progress
mpostol added a commit that referenced this issue Nov 4, 2019
@mpostol
Refactoring application architecture - remove recursion #6
b3dfdc3 
- Removing TreeNode controls from the CAS.UA.Model.Designer.Wrappers to CAS.UA.Model.Designer.Controls
- Created TreeNodeControl classes for all derived from Folder
- Work in progress
mpostol added a commit that referenced this issue Nov 4, 2019
@mpostol
Refactoring application architecture - remove recursion #6
24228e3 
- Removing TreeNode controls from the CAS.UA.Model.Designer.Wrappers to CAS.UA.Model.Designer.Controls
- Created ValidableTreeNodeControl
- Work in progress
mpostol added a commit that referenced this issue Nov 4, 2019
@mpostol
Refactoring application architecture - remove recursion #6
39e04c4 
- Removing TreeNode controls from the CAS.UA.Model.Designer.Wrappers to CAS.UA.Model.Designer.Controls
- Created selected TreeNode controls abstracted form the wrappers.
- Work in progress
mpostol added a commit that referenced this issue Nov 4, 2019
@mpostol
Refactoring application architecture - remove recursion #6
57c3236 
- Removing TreeNode controls from the CAS.UA.Model.Designer.Wrappers to CAS.UA.Model.Designer.Controls
- Created InstanceDesignTreeNodeControl
- Work in progress
mpostol added a commit that referenced this issue Nov 4, 2019
@mpostol
Refactoring application architecture - remove recursion #6
9025fd3 
- Removing TreeNode controls from the CAS.UA.Model.Designer.Wrappers to CAS.UA.Model.Designer.Controls
- Created ViewDesignTreeNodeControl
- Work in progress
mpostol added a commit that referenced this issue Nov 4, 2019
@mpostol
Refactoring application architecture - remove recursion #6
11167b3 
- Removing TreeNode controls from the CAS.UA.Model.Designer.Wrappers to CAS.UA.Model.Designer.Controls
- Created MethodDesignTreeNodeControl
- Work in progress
mpostol added a commit that referenced this issue Nov 4, 2019
@mpostol
Refactoring application architecture - remove recursion #6
20502ed 
- Removing TreeNode controls from the CAS.UA.Model.Designer.Wrappers to CAS.UA.Model.Designer.Controls
- Created ObjectDesignTreeNodeControl
- fixed compilation errors related to creation of the tree nodes.
- removed VariableDesignGeneric to simplify the in-memory model representation
- Work in progress
mpostol added a commit that referenced this issue Nov 4, 2019
@mpostol
Refactoring application architecture - remove recursion #6
ce3b5ac 
- Removing TreeNode controls from the CAS.UA.Model.Designer.Wrappers to CAS.UA.Model.Designer.Controls
- Created controls derived from InstanceDesignTreeNodeControl
- Work in progress
mpostol added a commit that referenced this issue Nov 4, 2019
@mpostol
Refactoring application architecture - remove recursion #6
40225d6 
- Removing TreeNode controls from the CAS.UA.Model.Designer.Wrappers to CAS.UA.Model.Designer.Controls
- Created all controls
- Work in progress
mpostol added a commit that referenced this issue Nov 4, 2019
@mpostol
Refactoring application architecture - remove recursion #6
d865a0a 
- Removing TreeNode controls from the CAS.UA.Model.Designer.Wrappers to CAS.UA.Model.Designer.Controls
- Moving BaseDictionaryTreeNode to remove circular references related to the TreeNode.
- Next step remove GetTreeNode and replace it by a factory.
- Work in progress
mpostol added a commit that referenced this issue Nov 5, 2019
@mpostol
Refactoring application architecture - remove recursion #6
ae7fb47 
- working on establishing model tree
- Work in progress - not tested
mpostol added a commit that referenced this issue Nov 5, 2019
@mpostol
Refactoring application architecture - remove recursion #6
c714119 
- working on establishing model tree
- Work in progress - not tested
mpostol added a commit that referenced this issue Nov 5, 2019
@mpostol
Refactoring application architecture - remove recursion #6
844bec0 
- removed dependency of the CAS.UA.Model.Designer.Wrappers on the CAS.UA.Model.Designer.Wrappers.MessageBox.Show
- Work in progress - not tested
@mpostol
Copy link
Owner Author

mpostol commented Nov 5, 2019 •
edited
Loading

Fixed circular references with the Controls. Consider moving this part to a separate assembly.

mpostol added a commit that referenced this issue Nov 6, 2019
@mpostol
Refactoring application architecture - remove recursion #6
ad2e695 
- Changed Unit Tests environment to MSTest
- fixed many typos
- Work in progress - not tested
- UT 👎
mpostol added a commit that referenced this issue Nov 6, 2019
@mpostol
Refactoring application architecture - remove recursion #6
6bb55e1 
- defined not critical test error Unit Test Fails in testing environment #39
- Work in progress - not tested
- UT 👎
mpostol added a commit that referenced this issue Nov 6, 2019
@mpostol
Refactoring application architecture - remove recursion #6
34ccad7 
- fixed and improved `BaseTreeNodeControlUnitTest`
- Work in progress - not tested
- UT 👎
mpostol added a commit that referenced this issue Nov 6, 2019
@mpostol
Refactoring application architecture - remove recursion #6
40b87a0 
- fixed and improved `FileMenuProviderControlUnitTest`
- Work in progress
- UT 👎
- integration tests 👎
- run test 👎
mpostol added a commit that referenced this issue Nov 6, 2019
@mpostol
Refactoring application architecture - remove recursion #6
eeac19f 
- improving Unit Tests, working on BaseTreeNodeControlUnitTest, SolutionTreeNodeControlUnitTest
- Work in progress
- UT 👎
mpostol added a commit that referenced this issue Nov 6, 2019
@mpostol
Refactoring application architecture - remove recursion #6
e80803c 
- fixed and improved Unit Tests in CAS.CommServer.UA.ModelDesigner.DesignStudio.UnitTest.Controls
- Work in progress
- UT 👎
mpostol added a commit that referenced this issue Nov 6, 2019
@mpostol
Refactoring application architecture - remove recursion #6
7eb2103 
- fixed existing unit tests
- UT 👍 some test are inconclusive and must be fixed - not blockers for this issue
- Work in progress
mpostol added a commit that referenced this issue Nov 8, 2019
@mpostol
Refactoring application architecture - remove recursion #6
f3f0b20 
- fixed AssemblyTraceEventUnitTest
- UT 👍 some test are inconclusive and must be fixed - not blockers for this issue.
- Work in progress
mpostol added a commit that referenced this issue Nov 9, 2019
@mpostol
Refactoring application architecture - remove recursion #6
2626675 
- fixed ProjectTreeNodeUnitTest
- UT 👍 some test are inconclusive and must be fixed - not blockers for this issue.
- Work in progress
@mpostol
Copy link
Owner Author

mpostol commented Nov 9, 2019

Done and reported a separate issue related to Wrappers4ProprtyGrid.
Przechwytywanie

@mpostol mpostol closed this as completed Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpostol mpostol

Labels
Architecture 🔀 Architecture Modification In Progress Issue In Progress
Projects
None yet
Milestone
Imports project from svn
Development

No branches or pull requests
1 participant
@mpostol