Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Avoid a memory leak when sorting domains (chapel-lang#24205)
Follow-up to PR chapel-lang#24147. Fixes a problem where the test `test/domains/vass/arrays-of-domains.chpl` would leak memory. For some reason (that I did not dig in to), code like `var x = shallowCopyInit(src)` calls the usual initCopy when applied to domains. But, in the sorting code, we need it to not do that, so I added a `pragma "no copy"` to avoid it. (Note that such variables already need `pragma "no auto destroy"` in the sorting code). Additionally, this PR removes testing for shellSortMoveElts (which is called within other sort code) from the test module SortTypes because this was making these test much slower, leading to timeouts. Reviewed by @vasslitvinov - thanks! - [x] full comm=none testing Future Work: * chapel-lang#16431 investigate "move" memory management for domains, which I worked around here
- Loading branch information