Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite code for better readability and performance #20

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Rewrite code for better readability and performance #20

wants to merge 4 commits into from

Commits on Dec 24, 2022

  1. Rewrite code for better readability and performance 

    In the JS files: recomputed salt and iv bytes, changed hexStringToBytes to something performs faster and is easier to read, removed unnecessary comments, and instead used self-explanatory variable names, replaced all quotes with either '' or ``, added ; at the end of each line.
In the CSS and HTML: used fewer lines of code, to have a better view for the JS code, since that is the main focus of bounty.html.
    @smunteanu6
    smunteanu6 committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    a2e7c0b View commit details
    Browse the repository at this point in the history

  2. Removed inexistent file from src.

    @smunteanu6
    smunteanu6 committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    2e7e241 View commit details
    Browse the repository at this point in the history

  3. Fixed comment

    @smunteanu6
    smunteanu6 committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    d0a99b1 View commit details
    Browse the repository at this point in the history

  4. Refactoring and fixed bug 

    Turned `decrypt()` into 2 functions, `decrypt()` which simply decrypts the cipher with the given password, salt, iv, and `decrypt_dom()` which runs when the user clicks on the decrypt button.
    @smunteanu6
    smunteanu6 committed Dec 24, 2022
    Configuration menu
    Copy the full SHA
    0b0f154 View commit details
    Browse the repository at this point in the history