Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Please add option to convert files to mp3 #55

Closed
erkiha opened this issue Mar 14, 2014 · 4 comments
Closed

Feature request: Please add option to convert files to mp3 #55

erkiha opened this issue Mar 14, 2014 · 4 comments
Assignees

Comments

@erkiha
Copy link

erkiha commented Mar 14, 2014

Would be nice to have an option to convert downloaded files to specific format, for example to mp3. Like current playerargs there should be converterargs parameter for that. Use case for this is to prepare files for specific mediaplayer which is not able to play m4a or ogg.
Addidtionally (or optionally) there can be an option to run script for every file downloaded which should get the file in command line parameter. This way it would be possible to define more elaborate automation tasks to do with downloaded files.

@np1 np1 self-assigned this Mar 20, 2014
@np1
Copy link
Contributor

np1 commented Mar 20, 2014

This would be useful. I really need to rewrite the configuration handling code as it's getting a bit messy. After it is rewritten I will look into implementing this.

@andrewwuan
Copy link

@np1 I'm looking into this issue recently. There are a couple audio tools that are able to convert between audio formats. I've found sox (http://sox.sourceforge.net/, a popular command-line audio tool) and audiotool (http://audiotools.sourceforge.net/index.html, a python library). Do you have preference on which one you want to use?
Personally I prefer sox because it's easier to install (with same procedure as mplayer). Also, we can make this library optional (user will be prompted to install it when he/she tries to convert audio format).

@np1
Copy link
Contributor

np1 commented Nov 23, 2014

Hi, I have recently implemented this using ffmpeg/avconv - https://github.com/np1/mps-youtube/commit/c66e9cec06f026bb6346c4e1642aab9193e46052. The implementation uses a config file containing preset commands (which are selectable from within the mpsyt program) so any other tool could be set up by the user to handle the conversion if they require.

You can test it by installing the version on the develop branch and typing help encode for more details.

Would appreciate any feedback / suggestions / improvements.

@np1
Copy link
Contributor

np1 commented Nov 24, 2014

This feature is available in v0.2.0

@np1 np1 closed this as completed Nov 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants