Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gdata.youtube.com for get_playlist; support more than 200 songs #72

Closed
wants to merge 7 commits into from
Closed

Conversation

ids1024
Copy link
Contributor

@ids1024 ids1024 commented Jan 22, 2015

This fixes #71.

This also removes some parameters unused by either pafy or mpsyt that
seemed difficult to implement with the new API.

There may be issues that need fixing. If nothing else, the definition of vid_data looks quite ugly.

Edit: The parameters I deleted should be added if possible.

This also removes some parameters unused by either pafy or mpsyt that
seemed difficult to implement with the new API.
@landscape-bot
Copy link

Code Health
Repository health decreased by 1% when pulling ebd3ecb on ids1024:develop into a28681c on np1:develop.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.61% when pulling adc8e2e on ids1024:develop into a28681c on np1:develop.

@ids1024
Copy link
Contributor Author

ids1024 commented Jan 23, 2015

Here is what I have not implemented:

  • added
  • is_cc
  • privacy
  • start
  • keywords
  • cc_license
  • category_id
  • time_updated
  • end

Playlist parameters:

  • description
  • likes
  • dislikes

Some of these may be easy to add back, while others seem to be missing from YouTube's response.

Edit: It looks like some of the trouble is the playlist I have been using. I will see what can be fixed.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.61% when pulling 5294ffa on ids1024:develop into a28681c on np1:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.16%) to 95.27% when pulling 3ee2f6a on ids1024:develop into e9572af on np1:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.14%) to 95.29% when pulling 8b1b8f8 on ids1024:develop into e9572af on np1:develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.22%) to 95.21% when pulling 6476150 on ids1024:develop into e9572af on np1:develop.

@landscape-bot
Copy link

Code Health
Repository health decreased by 1% when pulling 6476150 on ids1024:develop into e9572af on np1:master.

@ids1024
Copy link
Contributor Author

ids1024 commented Feb 12, 2015

@np1 Have you looked at the changes here? It does not provide all the data the currently implementation does, so it is probably not ready to merge. As far as I can tell, playlist likes and dislikes are not available with the new api. I can't find that on youtube.com either, so the feature was probably removed. Some of the others may also not be available with the new api,.

@np1
Copy link
Contributor

np1 commented Feb 12, 2015

Nope I haven't had a chance to look at it yet. Thanks for the PR. I will try to get to it soon.

@np1
Copy link
Contributor

np1 commented Feb 21, 2015

I am reluctant to include any changes that use gdata v2 because it will be turned off in the coming months.

"Note: The YouTube Data API (v2) has been deprecated as of February 26, 2014. In keeping with our deprecation policy, most API functionality that was subject to that policy will continue to be available until April 20, 2015. Support for some API features may be discontinued earlier if the corresponding features are also removed from YouTube prior to that date. See the Deprecation FAQ for answers to frequently asked questions about the deprecation."

Using v3 of the api requires obtaining a key for most request types - and obtaining a key requires agreeing to not access YouTube in the way that pafy does.

Some things specifically prohibited;

- access any portion of any YouTube audiovisual content by any means other than use of a YouTube player or other video player expressly authorized by YouTube;
- store copies of YouTube audiovisual content;

https://developers.google.com/youtube/2.0/developers_guide_protocol_deprecated
https://developers.google.com/youtube/youtube-api-list
https://developers.google.com/youtube/terms

I'm not sure how best to proceed at the moment..

@ids1024
Copy link
Contributor Author

ids1024 commented Feb 21, 2015

Version 3 of the api should be more similar to version 2 than what is currently used, so this is a step towards using that version. The TOS could be problematic, but I don't know what can be done.

@ids1024
Copy link
Contributor Author

ids1024 commented Dec 20, 2015

Superseded by #127.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Playlists Longer Than 200 Songs
4 participants