OnOffBooleanParser #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 10, 2017 14:12
|
Any reason we haven't merged this one yet? Otherwise good to go IMO |
|
One little note here, I see in the code that it only returns false when it's actually "off". The standard behavior from html forms is I think to not return the variable as a whole or have it empty. Could we design it in a way that it return true for "on" and false in all other cases? For me it sounds strange that such a parser would give null as it's not really a Boolean Parser then. What do you think? |
|
Agree, @yuvalherziger can we you push a change for that? Then we can merge this PR :) |
|
Yep! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.