Sanitizer: add address check by disabling memory limit (RagnarGrootKo…

…erkamp#365)

* add sanitizer flag

* add sanitizer flag

* --sanitizer disables memory limit

bin/program.py

@@ -31,7 +31,7 @@
 
 SANITIZER_FLAGS = '''
 cpp:
-    compile: -fsanitize=undefined
+    compile: -fsanitize=undefined,address
 '''
 
 # The cached languages.yaml for the current contest.

bin/tools.py

@@ -622,7 +622,7 @@ def build_parser():
     runparser.add_argument(
         '--sanitizer',
         action='store_true',
-        help='Run submissions with additional sanitizer flags (currently only C++).',
+        help='Run submissions with additional sanitizer flags (currently only c++). Note that this sets --memory unlimited.',
     )
 
     # Test

bin/util.py

@@ -1024,7 +1024,9 @@ def tail(string, limit):
 # Return memory limit in MB.
 def get_memory_limit(kwargs=None):
     memory_limit = 2048  # 2GB
-    if config.args.memory:
+    if config.args.sanitizer:
+        memory_limit = None  # disabled
+    elif config.args.memory:
         if config.args.memory != 'unlimited':
             memory_limit = int(config.args.memory)
         else:

doc/commands.md

@@ -106,7 +106,7 @@ Use `bt run -v` to show results for all testcases.
 - `--table`: Print a table of which testcases were solved by which submissions. May be used to deduplicate testcases that fail the same solutions.
 - `--overview`/`-o`: Print a live overview of the received verdicts for all submissions and testcases. If combined with `--no-bar` only the final table is printed.
 - `--no-testcase-sanity-checks`: when passed, all sanity checks on the testcases are skipped. You might want to set this in `.bapctools.yaml`.
-- `--sanitizer`: when passed, run submissions with additional sanitizer flags (currently only C++).
+- `--sanitizer`: when passed, run submissions with additional sanitizer flags (currently only c++). Note that this sets --memory unlimited.
 
 ## `test`