Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sudo_cast should not depend on default construction of T #504

Closed
mpusz opened this issue Oct 17, 2023 · 1 comment
Closed

sudo_cast should not depend on default construction of T #504

mpusz opened this issue Oct 17, 2023 · 1 comment
Labels
good first issue Good for newcomers refactor Modify existing code potentially causing breaking changes
Milestone
v2.3.0

Comments

@mpusz
Copy link
Owner

mpusz commented Oct 17, 2023

Most probably, we will drop the default constructibility requirement of std::regular for representation types. With that, our internal casting function sudo_cast should not depend on it as well.
@mpusz mpusz added good first issue Good for newcomers refactor Modify existing code potentially causing breaking changes labels Oct 17, 2023
@mpusz mpusz added this to the v2.3.0 milestone Jun 22, 2024
@mpusz
Copy link
Owner Author

mpusz commented Sep 6, 2024

Was no longer the case. However, the default constructibility was required in a few other places. Now, it is no longer needed.

@mpusz mpusz closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor Modify existing code potentially causing breaking changes
Projects
None yet
Milestone
v2.3.0
Development

No branches or pull requests
1 participant
@mpusz