Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake options for disabling docs, examples and tests #124

Closed
wants to merge 1 commit into from
Closed

Add CMake options for disabling docs, examples and tests #124

wants to merge 1 commit into from

Conversation

tambry
Copy link

@tambry tambry commented Jun 15, 2020

I'm trying to package this as a Debian package for use by team. Downloading things from the internet during a build is a big no-no for packaging (you ought to get them the necessary things from the repository). Since making the code work without Conan is more than I'm willing to bite and I only plan to package for internal use this simply adds options to turn off building docs, examples and tests. These are set to ON by default if mp-units is the top-level project, i.e. a normal dev setup.

@mpusz
Copy link
Owner

mpusz commented Jun 15, 2020

The build without docs, examples, and tests is just a build of the library, right? If this is true than https://mpusz.github.io/units/usage.html#cmake-conan should be enough. If you do not want to use Conan than you can work with src/CMakeLists.txt directly as this is meant to work independently and just provide a library to the end user (without changing his/her dev environment i.e. compilation warnings flags).

A top-level CMake entry point is meant for library development and this is why it should always build everything with really demanding compilation flags.

@tambry
Copy link
Author

tambry commented Jun 16, 2020

Using src/CMakeLists.txt seems like a fine option.

@tambry tambry closed this Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants