Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add options to disable part of the build #402

Closed
wants to merge 1 commit into from

Conversation

Lorac
Copy link

@Lorac Lorac commented Nov 10, 2022

Part of the build is not always useful. Make it possible only to deploy the source without testing.

We are currently using mpunit inside yocto system, and at the moment we need an extra patch to remove docs and tests. Having those options could clean up the way the recipe is built. We have to maintain a patch instead of specifying CMake options.

Do not change the current behaviour and keep the option to ON as default.

@gitpod-io
Copy link

gitpod-io bot commented Nov 10, 2022

Part of the build is not always useful. Make it possible only to deploy sources without testing.
@mpusz
Copy link
Owner

mpusz commented Nov 10, 2022

Hi,

First of all, it is great that you find this library useful in your work.
However, we do not plan to add CMake options to the build. See more in #278. I hope it helps?

@Lorac
Copy link
Author

Lorac commented Nov 10, 2022

Thanks for the information, we modified our yocto recipe to reflect that.

@Lorac Lorac closed this Nov 10, 2022
@Lorac Lorac deleted the patch-1 branch November 10, 2022 19:41
@mpusz
Copy link
Owner

mpusz commented Nov 11, 2022

You are welcome! The main reason not to do what you proposed is that it is not only about disabling parts of the build. You really do not want to import our compilation warnings and other development environment settings as well. The CMake file in ./src is pure and does not modify your compilation environment in any way, and should be used by users. The top-level file is meant as an entry point for project development (i.e. open in the IDE).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants