Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader resolution does not change with video-zoom #11039

Open
octopushugger opened this issue Dec 23, 2022 · 2 comments
Open

Shader resolution does not change with video-zoom #11039

octopushugger opened this issue Dec 23, 2022 · 2 comments

Comments

@octopushugger
Copy link

octopushugger commented Dec 23, 2022

I want to scale with shaders when zooming but mpv only uses internal algorithms for it.

  • mpv version: 0.35.0-37-gf9d0b0c08a
  • Platform and Version: Win11
  • Source of the mpv binary: Scoop

Reproduction steps

Change video-zoom while using any shader that uses output resolution in its processing.

Expected behavior

Shader re-render at new resolution when video-zoom is changed.

@hooke007
Copy link
Contributor

Could you show the shader that "uses output resolution in its processing"? I've never saw this kind of scaling shaders.

@octopushugger
Copy link
Author

Ravu-zoom doesn't trigger for video-zoom or if upscaling was already required then ravu-zoom will upscale before video-zoom's crop(at least I assume it works by cropping) and then mpv will upscale with whatever "scale" is set to. Ideally this would be one smooth process with just ravu-zoom.

I think the issue might be that video-zoom does not affect HOOKED or is not loaded until after user shaders are run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants