Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avif screenshot issue #12881

Closed
CCCAUCHY opened this issue Nov 13, 2023 · 5 comments
Closed

avif screenshot issue #12881

CCCAUCHY opened this issue Nov 13, 2023 · 5 comments
Labels

Comments

@CCCAUCHY
Copy link

Important Information

  • mpv version v0.36
  • Windows 10 pro 22H2 19045.3636
  • Source of the mpv binary

Reproduction steps

using config screenshot-format=avif then press s to save a screenshot.

Expected behavior

Screenshot saved successfully

Actual behavior

error

Log file

[ 1.451][e][screenshot] Could not find encoder 'libaom-av1', for saving images

Sample files

every video

@zhongfly
Copy link

zhongfly commented Nov 13, 2023

Because the binary you download don't have av1 encoder as log said.
You should ask the maintainer of https://github.com/eko5624/mpv-win64 to fix it, not here.

You can use shinchiro's build:https://github.com/shinchiro/mpv-winbuild-cmake/releases/latest or my build:https://github.com/zhongfly/mpv-winbuild/releases/latest.
Those builds have av1 encoder rav1e.

@hooke007
Copy link
Contributor

hooke007 commented Nov 13, 2023

Your build had rav1e only.

Unfortunately, it seems he forgot to link it in ffmpeg --enable-librav1e

also have the same issue with config screenshot-avif-encoder=libdav1d

BTW, libdav1d is a decoder. You didn't use the correct name of rav1e.

@Andarwinux
Copy link
Contributor

The performance of librav1e is not good for still picture, not even as good as libaom. libsvtav1 is a better choice if your CPU supports AVX512.

@CCCAUCHY
Copy link
Author

Because the binary you download don't have av1 encoder as log said. You should ask the maintainer of https://github.com/eko5624/mpv-win64 to fix it, not here.

You can use shinchiro's build:https://github.com/shinchiro/mpv-winbuild-cmake/releases/latest or my build:https://github.com/zhongfly/mpv-winbuild/releases/latest. Those builds have av1 encoder rav1e.

what is the different between shinchiro's and yours?

@Andarwinux
Copy link
Contributor

Because the binary you download don't have av1 encoder as log said. You should ask the maintainer of https://github.com/eko5624/mpv-win64 to fix it, not here.
You can use shinchiro's build:https://github.com/shinchiro/mpv-winbuild-cmake/releases/latest or my build:https://github.com/zhongfly/mpv-winbuild/releases/latest. Those builds have av1 encoder rav1e.

what is the different between shinchiro's and yours?

There's no difference, they both use the same toolchain to build.

Checks the mpv repository every hour for updates. If there is an update and it is relevant to the windows build, it will automatically run the compilation and release it on success.

@sfan5 sfan5 closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants