Something's not right in ao_rsound.c

[OrdinaryMagician]

latest git master, x86_64 arch linux

Reproduction steps

Compile.

Expected behavior

It compiles.

Actual behavior

It doesn't compile.

In file included from ../audio/out/ao_rsound.c:31:0:
../audio/out/ao_rsound.c:162:13: error: request for member 'deprecation_message' in something not a structure or union
             .deprecation_message = "request --audio-device support on issue tracker"),
             ^
/home/marisa/.cache/pacaur/mpv-build-git/src/mpv/options/m_option.h:551:32: note: in definition of macro 'OPT_GENERAL'
     {.name = optname, .flags = flagv,                                   \
                                ^~~~~
../audio/out/ao_rsound.c:161:9: note: in expansion of macro 'OPT_STRING'
         OPT_STRING("port", port, 0
         ^~~~~~~~~~

Log files

N/A

Sample files

N/A

[ghost]

This probably fixes it, though I didn't try it myself.

[OrdinaryMagician]

It did.

[ghost]

Thanks. Are you actually using rsound, or was it just automatically enabled because it was on your system?

[OrdinaryMagician]

Possibly the latter. I haven't checked what the AUR package enables.

[qmega]

If you're using the mpv-git AUR package, it doesn't explicitly enable anything other than the shared library and zsh completion. mpv's build enables whatever it finds automatically and the package picks up whatever dependencies are linked against. If rsound were to be removed or default-disabled in mpv, the package would stop using it next time you built it. I think you'd have to use --ao=rsound to actually use it, so if you don't know you are then you're probably not.

On Sep 12, 2016, at 07:26, Marisa Kirisame notifications@github.com wrote:

Possibly the latter. I haven't checked what the AUR package enables.

―
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[OrdinaryMagician]

Oh well, I do have rsound installed and it's listed as a dependency of mpv-build-git so...

[ghost]

I've only asked because I never met anyone who actually used it. (As in, really used it, not just built it.)