Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse wheel bindings are controlled by MOUSE_BTN3 and 4 instead of AXIS_UP and AXIS_DOWN #3602

Closed
FichteFoll opened this issue Sep 29, 2016 · 4 comments

Comments

@FichteFoll
Copy link

FichteFoll commented Sep 29, 2016

mpv verion

0.20.0 64 bit, Windows 7

Reproduction steps

Try to bind mouse wheel to a different action (or none):

# Volume on mouse wheel
AXIS_UP   add volume 2
AXIS_DOWN add volume -2

Expected behavior

On scrolling, volume should get changed.

Actual behavior

Scrolling still seeks.

@wiiaboo
Copy link
Member

wiiaboo commented Sep 29, 2016

Wheel up and down is MOUSE_BTN3 and MOUSE_BTN4, respectively, not AXIS_UP and AXIS_DOWN.

@FichteFoll
Copy link
Author

Uh, okay, thanks. It does work indeed.

But this is stupid because the mouse buttons 3 and 4 actually exist and get pushed to 5 and 6 instead, it seems. And because the comments in the default input.conf specifically mention that AXIS_* handles the mouse wheel.

@FichteFoll FichteFoll changed the title Custom mouse wheel bindings on Windows don't work Mouse wheel bindings are controlled by MOUSE_BTN3 and 4 instead of AXIS_UP and AXIS_DOWN Sep 29, 2016
@rossy
Copy link
Member

rossy commented Sep 30, 2016

Yeah, this should be fixed. It seems like only the macOS and Wayland backends emit AXIS_UP and AXIS_DOWN. macOS seems to emit AXIS_UP and AXIS_DOWN for touchpads that support precise scrolling and MOUSE_BTN3 and MOUSE_BTN4 for normal scroll wheels. The Windows backend could be changed to support AXIS_UP and AXIS_DOWN, but then MOUSE_BTN3 and MOUSE_BTN4 would stop working because there's no easy way to tell if a scroll event was generated from a device that supports precise scrolling or not. Maybe MOUSE_BTN3 and MOUSE_BTN4 should be deprecated or emulated on top of AXIS_UP and AXIS_DOWN?

@mia-0
Copy link
Member

mia-0 commented Dec 3, 2017

957e9a3

@mia-0 mia-0 closed this as completed Dec 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants