Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change of seek command handling #3883

Closed
mgcrea opened this issue Dec 8, 2016 · 1 comment
Closed

Breaking change of seek command handling #3883

mgcrea opened this issue Dec 8, 2016 · 1 comment

Comments

@mgcrea
Copy link

mgcrea commented Dec 8, 2016

mpv version and platform

# mpv --version
mpv 0.22.0 (C) 2000-2016 mpv/MPlayer/mplayer2 projects
 built on Mon Nov 21 14:57:51 UTC 2016
ffmpeg library versions:
   libavutil       55.34.100
   libavcodec      57.64.100
   libavformat     57.56.100
   libswscale      4.2.100
   libavfilter     6.65.100
   libswresample   2.3.100
ffmpeg version: 3.2
# lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 16.04.1 LTS
Release:	16.04
Codename:	xenial

Reproduction steps

Not sure if it's an actual bug/regression or if I was doing something wrong, but seeking seems to have changed the way it works.

It used to properly seek, no the command seems ignored (looks like it might be sent too early).

JS pseudo code showing the commands sent:

self.socket.write({command: ['loadfile', media.path, 'replace']});
self.once('file-loaded', function onFileLoaded() {
  self.socket.write({command: ['seek', options.seek / 1000, 'exact']});
});
self.socket.write({command: ['set_property', 'pause', false]});

Expected behavior

Properly seeks.

Actual behavior

Does not seek.

Log file

http://sprunge.us/DWGD

Sample files

Not needed


By the way, I'm wondering if there is a way to pass a --start like flag to set the seek when doing the loadfile command, I guess it would help prevent this.

@mgcrea
Copy link
Author

mgcrea commented Dec 8, 2016

Fixed it using the start=+100.200 param, I guess it's a strange use case. So I'll close this.

@mgcrea mgcrea closed this as completed Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant