Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird artifacts with d3d11 #5353

Closed
rld243 opened this issue Jan 4, 2018 · 7 comments
Closed

Weird artifacts with d3d11 #5353

rld243 opened this issue Jan 4, 2018 · 7 comments
Assignees
Labels

Comments

@rld243
Copy link

rld243 commented Jan 4, 2018

mpv version and platform

Windows 10 Fall Creators Update (Build 16299)
Nvidia GTX 960 (388.71)

mpv 0.28.0-74-ga9a4d6349a Copyright © 2000-2018 mpv/MPlayer/mplayer2 projects
built on Thu Jan 4 16:47:13 UTC 2018
ffmpeg library versions:
libavutil 56.7.100
libavcodec 58.9.100
libavformat 58.3.100
libswscale 5.0.101
libavfilter 7.10.100
libswresample 3.0.101
ffmpeg version: N-89690-g18fbfd7bf8

Reproduction steps

Open any file with --no-config --gpu-api=d3d11 --scale=ewa_lanczossharp and go fullscreen

Expected behavior

Video should work fine

Actual behavior

Have some weird artifacts
Examples:
https://0x0.st/sPnr.png
https://0x0.st/sPns.png
Doesn't happen without --scale=ewa_lanczossharp or with --gpu-api=opengl

Log file

http://0x0.st/sPnK.txt

Sample files

Happens with any video (at least with any *.mkv I have)

@dnmTX
Copy link

dnmTX commented Jan 4, 2018

Same here when using ewa_lanczos with d3d11,after awhile start having black screen with sound only(.mkv file).Uploading log file as well for better troubleshooting.
P.S. No problems with spline36 also same GPU driver as OP
log.txt

@zc62
Copy link
Contributor

zc62 commented Jan 5, 2018

Strange. I do observe these artifacts (though not as serious as you observed) with shinchiro's build (20180104). But when I was trying my own build, artifacts were gone.
Logs:
sourceforge_010418.log
my_build.log
Windows 7, GTX970 388.71

@shinchiro
Copy link
Contributor

This my guess. Probably this is another spirv-cross bug yet? Too bad mpv doesn't print spirv-cross git version

@zc62
Copy link
Contributor

zc62 commented Jan 5, 2018

@kevmitch kevmitch added the os:win label Jan 5, 2018
@rossy
Copy link
Member

rossy commented Jan 5, 2018

I get this as well. It seems to be a change in how barriers are emitted by glslang, which is exposing SPIRV-Cross's limited support for SPIR-V barriers. Working on a fix now.

@rossy
Copy link
Member

rossy commented Jan 10, 2018

This should be fixed in SPIRV-Cross git master.

@rossy rossy closed this as completed Jan 10, 2018
@dnmTX
Copy link

dnmTX commented Jan 10, 2018

Thank you @rossy for taking care of this.Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants