-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make --sub-auto and --audio-file-auto possible to autoload but do not prefer external tracks #5433
Comments
If there's internal english subtitles and the user chose to get external english subtitles, I'd figure external being prioritized makes sense. |
What if you want the internal eng sub but there are non-eng external subs preventing you from auto-selecting the eng sub? (Suppose you want to keep them, and you don't want to waste energy to launch mpv from the terminal and add Auto-selecting between two eng subs requires #5133. But that is intended for internal vs internal, external vs external. There are still some other possible reasons to choose internal ones:
I do agree that the case you stated may happen. I don't know what average users see. In my personal experience, I see "same language internal audio vs external audio, prefer internal audio" far more than "same language internal sub vs external sub, prefer external sub", even more than "same language internal and external sub both exist". |
Or just make more options for I think it is reasonable since even Now we have |
honestly, I didn't understand why they wouldn't introduce this, for example, the --alang=jpn parameter,ja doesn't work when external tracks are in other languages, but I would like to choose Japanese and then switch to external if necessary |
@AdventurerRussia This is because most core developers do not have similar use cases as we do. For example, wiiaboo already stated that they found the original design reasonable. Core developers did not close my issues, meaning they are open to this idea and want to see a PR for possible outcomes, and I did propose a seemingly more reasonable order in #6071, but unfortunately over the years I did not have chance to implement it myself (mainly because I seldom watch multi-track videos now). If you are interested in changing this, I hope my idea in #6071 can help (not sure how |
this is very funny because mpv is used in very different scenarios. But the functionality for external tracks has to be modified with scripts. Although many trackers release anime with external tracks. |
@AdventurerRussia Well, as I have already explained, keep complaining will not automatically make this change. To the opposite, too many complaints are likely to make core developers unhappy and reject this feature request. Instead of repeating "I do not understand", you have 3 better options to possibly make things change:
In any case, repeating "I don't understand", "what is the point", etc. will only make things worse. I do appreciate it if you can realize this. |
The "do not select" here is NOT "strictly not selecting" (as what has been done to
--external-files
recently). This change simply makes auto-loaded external tracks seen as if they are internal tracks (but with higher tid than real internal ones) when selecting the track.~~I think this behavior sounds more natural because when everything set to automatic, I don't really care which of the tracks are internal and which are external.
#5127 is probably saying the same thing. When auto-loading external files, all of the internal tracks with desired *slang will completely be ignored, because
external
has very high priority. IMOexternal
should have such high priority when user specify external tracks with--sub-file
or--audio-file
, but when using auto-loading, it is most likely that users just want to make every track selectable.There are external files not because users themselves made those files (and even want those files have higher priority), but because users simply got a bunch of files somewhere and simply want to play them.
EDIT: see my second comment below.
The text was updated successfully, but these errors were encountered: