Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linux] no osc #597

Closed
SergeiAlekseev opened this issue Feb 27, 2014 · 18 comments
Closed

[linux] no osc #597

SergeiAlekseev opened this issue Feb 27, 2014 · 18 comments

Comments

@SergeiAlekseev
Copy link

From ./waf configure:
Checking for Lua : yes (version found: 51deb)
but osc is missing.
Do i need to install more lua dev packages? Or something?

@ghost
Copy link

ghost commented Feb 27, 2014

No, this should be enough. I don't know why the osc wouldn't show up for you. Maybe post a log of mpv with -v?

@mc4man
Copy link

mc4man commented Feb 27, 2014

Don't you need liblua5.2 for Osc or has something changed?

@ghost
Copy link

ghost commented Feb 27, 2014

No, both 5.1 and 5.2 should work.

@SergeiAlekseev
Copy link
Author

With 5.1 dev uninstalled and 5.2 dev installed -- "Checking for Lua : no"
-v output:
http://metafight.ru/files/mpv-output-0.txt
Previous build i have (3.0) is working properly with osc.
http://metafight.ru/files/mpv-output-1.txt

@ghost
Copy link

ghost commented Feb 28, 2014

This shoiuld work. But now I saw:

serge@debian:~/.0-source/mpv$ ./waf build
...
serge@debian:~/.0-source/mpv$ ./mpv "/media/JUNK/Films/VIDEO_TS.tmp-incomplete.m4v" -v

waf doesn't put the mpv binary on the top level directoy. It's in build/. Maybe the mpv binary in the top level dir is an old one?

@SergeiAlekseev
Copy link
Author

Oops. Shame on me.
Yes, it's my attempt to build with checkinstall.
OSC is working, i am so sorry.

I have some question. I don't think this is mpv issue, but latest version is spamming output in emelfm2 file manager.
http://metafight.ru/files/mpv-git.txt
3.0 build is producing right output, rewriting info line:
http://metafight.ru/files/mpv-30.txt
Can you please tell me what exactly changed, i want to report to emelfm2 developer about it.
Because if started from terminal, output is fine.

@ghost
Copy link

ghost commented Mar 1, 2014

If stderr is not a terminal (isatty() returns 0), then we don't write \r anymore.

@giselher
Copy link
Member

giselher commented Mar 6, 2014

I have the same problem but i am using the right binary.

@giselher
Copy link
Member

giselher commented Mar 6, 2014

Here is the log https://gist.github.com/giselher/9386553
It looks like It loads the osc but it just doesn't show it on the video. The issue happens with both wayland(shm/gl) and x11(vdpau/gl).

@ghost
Copy link

ghost commented Mar 6, 2014

Are subitltes visible?

@giselher
Copy link
Member

giselher commented Mar 6, 2014

Yes

@ghost
Copy link

ghost commented Mar 6, 2014

From your log, it looks like it didn't get input.

@ghost
Copy link

ghost commented Mar 6, 2014

PS: not sure though, maybe -v is not enough. Can you make a log with -v -v -v?

@giselher
Copy link
Member

giselher commented Mar 6, 2014

@giselher
Copy link
Member

giselher commented Mar 6, 2014

I going to do some git bisect now, I found a commit where it still works

@giselher
Copy link
Member

giselher commented Mar 6, 2014

03624a174702dd72adc3043e5bb3a5d7c476570d is the first bad commit
commit 03624a174702dd72adc3043e5bb3a5d7c476570d
Author: wm4 <wm4@nowhere>
Date:   Mon Feb 17 02:35:00 2014 +0100

    input: don't let builtin bindings overwrite user bindings

    This was already done, except when the bindings were in different input
    sections. This commit fixed it. Useful for scripts, probably.

:040000 040000 b0f88a10e1cdb0f474e4d62c09bd09e0eeeec950 b837d88f7a7f750060a5db4a92d9b2584661cce6 M  input

EDIT: In my config I set the mouse events to ignore. Sorry for the inconvenience.

@ghost
Copy link

ghost commented Mar 6, 2014

Thanks for finding this. It means that everyone who copied the default input.conf into ~/.mpv/ (before all default input.conf entries were commented) will have this problem. Looks like my approach trying to allow users to override script bindings doesn't quite work.

@ghost
Copy link

ghost commented Apr 8, 2014

Well, I'm assuming the issue was addressed.

@ghost ghost closed this as completed Apr 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants