Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow scripts-opts in multiple lines #6294

Closed
sebast889 opened this issue Nov 7, 2018 · 6 comments
Closed

Allow scripts-opts in multiple lines #6294

sebast889 opened this issue Nov 7, 2018 · 6 comments

Comments

@sebast889
Copy link

Currently if you use the scripts-opts=... in mpv.conf it only allows the options to be specified in this one line.

Please allow multiple scripts-opts= lines to take effect so that specific scripts-opts can be used in different profiles as well as easier reading of the options.

@wiiaboo
Copy link
Member

wiiaboo commented Nov 7, 2018

Use -add and/or -append: https://mpv.io/manual/master/#list-options

@wiiaboo wiiaboo closed this as completed Nov 7, 2018
@sebast889
Copy link
Author

It works when doing everything globally but for some reason it doesn't work for me when doing the following in mpv.conf:

script-opts-append=osc-layout=box #globally

[extension.mp4]
script-opts-append=osc-layout=bottombar

When I play a .mp4 it still shows the box layout

@wiiaboo
Copy link
Member

wiiaboo commented Nov 7, 2018

I think you can't change OSC options after opening the player, since the OSC script reads them only once at the start. It works with ytdl_hook because it's run on-demand, not constantly like the OSC.

@sebast889
Copy link
Author

But if they're defined in mpv.conf shouldn't all options in it be read at the start? Or are profile settings interpreted differently that they are read after player start?

@wiiaboo
Copy link
Member

wiiaboo commented Nov 7, 2018

I haven't read the code, but I'd assume the options in a profile aren't applied at the start, only after you've opened a .mp4.

@sebast889
Copy link
Author

In that case can I request for script-opts to be applied at the start so that profiles can make use of specific script-opts that are set before opening the media file? Unless it is too big a design change..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants