Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong subtitle timing #68

Closed
otommod opened this issue Apr 29, 2013 · 7 comments
Closed

Wrong subtitle timing #68

otommod opened this issue Apr 29, 2013 · 7 comments

Comments

@otommod
Copy link
Contributor

otommod commented Apr 29, 2013

So I was watching this movie yesterday and I had this weird timing problem.
It was displaying the subs of around 01:00:00,000 at the start of the movie and it continued from there.
I tried it on mplayer2 and it played them alright though.
Subs were on an external .str file.

@ghost
Copy link

ghost commented Apr 29, 2013

It's a known issue, but we couldn't tracked down it yet.

Did you compile mpv with gcc 4.8 by any chance?

@otommod
Copy link
Contributor Author

otommod commented Apr 29, 2013

Yes I did.

@ghost
Copy link

ghost commented Apr 29, 2013

Yep, compilation somehow breaks with gcc 4.8. Could be either a bug in the mpv code (ignores hours for some reason), or a gcc compiler bug. We haven't touched this part of the code for quite a while, though.

@otommod
Copy link
Contributor Author

otommod commented Apr 29, 2013

You are right, it is GCC's problem. I just compiled with Clang 3.2 and subs work fine.

@ghost
Copy link

ghost commented Apr 29, 2013

As expected, it was a problem with undefined behavior, and gcc-4.8's optimizer is probably more aggressive than earlier versions, which caused the issue. Commit d98e61e should fix this. Can someone confirm?

@otommod
Copy link
Contributor Author

otommod commented Apr 30, 2013

I can confirm that this is fixed. Thank you very much!

@ghost
Copy link

ghost commented Apr 30, 2013

Thanks for testing.

@ghost ghost closed this as completed Apr 30, 2013
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant