Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced srt subs #9419

Closed
Darth8Fener opened this issue Nov 7, 2021 · 5 comments
Closed

Forced srt subs #9419

Darth8Fener opened this issue Nov 7, 2021 · 5 comments

Comments

@Darth8Fener
Copy link

This is the second "stable" (how can you call it stable?!) release without that forced srt subs work (basic function), then I suppose that I have to require it as a new feature!
Or you prefer that I resolve the problem?!

Best regards,

Darth Fener

@Doofussy2
Copy link

There is a PR for this. It just hasn't been merged

#8865

@jeeb
Copy link
Member

jeeb commented Nov 8, 2021

I tried to find a bug report about "srt forced" in my email's github inbox and I couldn't find one, so not sure what this was a reference towards (bug VS feature).

What something being broken means is that:

  • None of the people poking at the code utilize the feature.
  • None of the automated tests that are set up notice the breakage (there are a few at least in mpv, but definitely not many).

I think it's as simple as that.

@Doofussy2 thanks for noting. Fun how it is within a PR that contains XYZ different things which makes it extra fun to try and dive into it. I guess it needs to be looked into piece-by-piece so that if there's anything clearly merge'able it should be taken in.

@daed-alus
Copy link

calm our tits baby jesus its only broken for over a year now

and as said
None of the people poking at the code utilize the feature.
aka no one responsable for the main code is using its own software g2k

@Doofussy2
Copy link

calm our tits baby jesus its only broken for over a year now

and as said None of the people poking at the code utilize the feature. aka no one responsable for the main code is using its own software g2k

Actually, the contributor that broke it, has also fixed it in the PR that I linked.

@Dudemanguy
Copy link
Member

This was fixed by #12100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants