Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--icc-force-contrast does not work with --vo=gpu-next #9752

Open
aufkrawall opened this issue Jan 23, 2022 · 5 comments
Open

--icc-force-contrast does not work with --vo=gpu-next #9752

aufkrawall opened this issue Jan 23, 2022 · 5 comments

Comments

@aufkrawall
Copy link

aufkrawall commented Jan 23, 2022

icc-profile-auto
icc-force-contrast=inf

--vo=gpu:
Screenshot_20220123_202114

--icc-force-contrast=inf should turn BT.1886 gamma curve into pure power 2.4, but it doesn't with --vo=gpu-next:
Screenshot_20220123_202028

--vf=format:gamma=gamma2.4 can be used as a workaround.

Log:
output.txt

latest mpv & libplacebo git-master as of today.
Tested on Linux Xorg.

I btw. still think that pure power gamma 2.4 would be a better default for rec709 content, as BT.1886 just looks too bright with most of the content on any display that doesn't have an extremely low black point.

@CrHasher
Copy link

Please remove label "os:linux", it applies also to windows. In addition "gamma-factor" doesn't work.

@OrangeColaJuice
Copy link

Is the "bt.1886" treated like something in-between sRGB and gamma2.2 because it has hard-coded 1000 contrast over the spec's formula? That's definitely how it feels to me after experimenting.

@haasn
Copy link
Member

haasn commented Feb 23, 2023

Is the "bt.1886" treated like something in-between sRGB and gamma2.2 because it has hard-coded 1000 contrast over the spec's formula? That's definitely how it feels to me after experimenting.

Yes and no. libplacebo assumes 1000:1 contrast by default for SDR displays with unknown contrast information. If you use an ICC profile, it will instead take the effective contrast of the ICC profile's LUTs. (Note that --icc-force-contrast is currently ignored by --vo=gpu-next, this is a known limitation.)

In theory BT.1886 can be tuned to any contrast point you want, but the mpv integration does not expose all options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
@CrHasher @haasn @Dudemanguy @aufkrawall @OrangeColaJuice and others