Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update axios dependency to 0.21.1 #34

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Conversation

davidfishlock
Copy link
Contributor

Addresses a high severity security advisory on axios peer dependency:
https://www.npmjs.com/advisories/1594

@mpyw
Copy link
Owner

mpyw commented Jan 13, 2021

Build seems to be failing 😢
Duplicates of #33 (But I don't close any PR until one of them is merged)

@davidfishlock
Copy link
Contributor Author

@mpyw the build failures are unrelated to this PR. All builds on this repository will have been failing since 20th October, when node 15 became the stable version.

The Travis config runs against two node versions:

The build is failing on node 15 because the test run is generating unhandled promise rejections. You can see these in the log output for build runs of the last successful PR on this repo:

(node:6693) UnhandledPromiseRejectionWarning: Error: EBADF: bad file descriptor, close

The difference in node 15 is that these unhandled promise rejections will terminate the process. So currently any build on this repo will be passing on node < 15 and failing on node 15+.

I can't reproduce these file descriptor failures locally, this could be something specific to the Travis or linux environment and/or something specific to the way the tests are being set up.

These will either need to be fixed for any future PRs to pass on this repo, or the Travis runs will need to stop running on node 15.

@mpyw mpyw merged commit f1697be into mpyw:master Jan 14, 2021
This was referenced Jan 14, 2021
@mpyw
Copy link
Owner

mpyw commented Jan 14, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants